test: cleanup operator_test.go to only make local calls (no internet dependencies) - #350
Draft
samlaf wants to merge 3 commits into
Draft
test: cleanup operator_test.go to only make local calls (no internet dependencies)#350samlaf wants to merge 3 commits into
samlaf wants to merge 3 commits into
Conversation
| return | ||
| } | ||
| marshalledOperatorMetadata, err := json.Marshal(operatorMetadata) | ||
| require.NoError(t, err) |
Contributor
There was a problem hiding this comment.
I forgot what was diff between require and assert?
shrimalmadhur
approved these changes
Sep 24, 2024
samlaf
marked this pull request as draft
September 27, 2024 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were failing this morning when
http://example.comwas returning 500 errors temporarily. We shouldn't depend on any external servers for tests, so this PR is a wip DRAFT for this goal.Super ugly right now, but at least it's working. Just need to clean this up.