Skip to content

chore: post-review cleanup — docs drift, CONTEXT.md section order, review nits #374

Description

@LeXwDeX

Findings from the two-axis review of 44c5843..HEAD (both PASS, info-level)

  1. AGENTS.md Git Workflow prose/table still says the dev PR gate is Typecheck-only — now Typecheck + Unit Tests (linux) (chore(ci): raise the dev PR gate to Typecheck + Unit Tests (linux) (middle-tier gating) #370).
  2. CONTEXT.md: the decide(dag): 'one live DAG per user goal' is documented as an Invariant but is an unenforced convention #348 Conventions header was inserted mid-list, accidentally demoting 5 original Invariants (incl. the engine-enforced gated-checkpoint obligation) into Conventions.
  3. memory-search: a no-op if-split (both arms identical) — restore the || form.
  4. blocks.ts: BLK-02 collision check inlined as an IIFE — extract a named helper per the Style Guide.
  5. Documented delta: fix(goal): GoalLoop not wired into server request-context node graph — standing goals stall on headless serve/web/desktop #340's third acceptance line (serve-mode goal-past-turn-1 e2e) is covered functionally by e2e-loop.test.ts behavior tests + the wiring probe for the exact failure class; no third harness.

Acceptance

  • the five fixes above land

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions