Draft
Conversation
…r than temporary files for communication (WIP) (cherry picked from commit a29b296)
in case the video encoder doesn't keep up with the speed at which frame render workers render frames, it would lead to overrunning memory. this throttling ensures that there are only a couple frames kept in memory as buffer (cherry picked from commit 6e1e47d)
temporarily re-adds `process.on` to handle single-frame renders, render_frame.js hasn't implemented using node-ipc for worker communication when rendering a single frame
ILW8
force-pushed
the
update-renderer
branch
from
e4ed2f7 to
835c542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to optimize the rendering process by eliminating the
part that buffers frames generated by the workers on disk while the final video
encoder assembles them together into a video file. Instead, frame data is
passed between the workers and the renderer through IPC in-memory.
This PR is currently a work-in-progress
Although this code has been working fine for many months on a private server,
there are a couple of potential failure points to be addressed as well as an
update to the rendering progress message