split count public getter, events distribution feature#257
Merged
Conversation
|
@feyishola Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Implementation
split_count(e: Env) -> u32 (line 269-272): Returns the total number of splits created
recurring_count(e: Env) -> u32 (line 299-302): Returns the total number of recurring payments created
dispute_count(e: Env) -> u32 (line 241-244): Returns the total number of disputes created
Each function follows the same pattern as the existing escrow_count function:
Calls bump_instance to extend TTL
Reads the corresponding counter from storage using read_counter
In [splitter_test.rs]
test_split_count_starts_at_zero: Verifies counter starts at 0
test_split_count_increments_on_create: Verifies counter increments correctly (tests 3 splits with IDs 1, 2, 3)
In [recurring_test.rs
test_recurring_count_starts_at_zero: Verifies counter starts at 0
test_recurring_count_increments_on_setup: Verifies counter increments correctly (tests 3 recurring payments with IDs 1, 2, 3)
In [dispute_test.rs]
test_dispute_count_starts_at_zero: Verifies counter starts at 0
test_dispute_count_increments_on_open: Verifies counter increments correctly (tests 3 disputes with IDs 1, 2, 3)
These public getters expose the counter keys that already existed in DataKey but weren't accessible to indexers. Indexers can now use these functions to know when to stop paginating through splits, recurring payments, and disputes.All changes maintain consistency with the existing codebase patterns and the existing escrow_count implementation.Summary of Implementation
split_count(e: Env) -> u32 (line 269-272): Returns the total number of splits created
recurring_count(e: Env) -> u32 (line 299-302): Returns the total number of recurring payments created
dispute_count(e: Env) -> u32 (line 241-244): Returns the total number of disputes created
Each function follows the same pattern as the existing escrow_count function:
Calls bump_instance to extend TTL
Reads the corresponding counter from storage using read_counter
In [splitter_test.rs]
test_split_count_starts_at_zero: Verifies counter starts at 0
test_split_count_increments_on_create: Verifies counter increments correctly (tests 3 splits with IDs 1, 2, 3)
In [recurring_test.rs]
test_recurring_count_starts_at_zero: Verifies counter starts at 0
test_recurring_count_increments_on_setup: Verifies counter increments correctly (tests 3 recurring payments with IDs 1, 2, 3)
In [dispute_test.rs]
test_dispute_count_starts_at_zero: Verifies counter starts at 0
test_dispute_count_increments_on_open: Verifies counter increments correctly (tests 3 disputes with IDs 1, 2, 3)
These public getters expose the counter keys that already existed in DataKey but weren't accessible to indexers. Indexers can now use these functions to know when to stop paginating through splits, recurring payments, and disputes.All changes maintain consistency with the existing codebase patterns and the existing escrow_count implementation.
closes #182
closes #183
closes #184
closes #185