fix: resolve FE-143, FE-144, FE-152, FE-153 (#271 #272 #273 #274)#343
Merged
BigBen-7 merged 1 commit intoMay 29, 2026
Merged
Conversation
, Lead-Studios#274 - Lead-Studios#274: Replace raw <img> with AppImage for performer photos in event details page (width/height/sizes props set) - Lead-Studios#273: Lazy-load LandingTestimonials and LandingFooter via next/dynamic (ssr:false) with skeleton placeholders; remove inline footer from page.tsx - Lead-Studios#272: Add bulk CSV check-in upload to verification page — client-side CSV parse, parallel POST to /api/tickets/check-in, succeeded/failed summary - Lead-Studios#271: Add 13 unit tests for ticketCheckIn and ticketVerification (happy path, already-used, network error, expired, revoked, unavailable)
|
@Userhorlie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
BigBen-7
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all four open issues assigned to me in a single commit.
Closes #274 — FE-153: Image optimisation for event cover photos
<img>withAppImage(wrapsnext/image) for performer photos in the event details pagewidth={64},height={64}, andsizes="64px"props for correct optimisationCloses #273 — FE-152: Lazy-load below-the-fold sections on the landing page
src/components/landing/LandingFooter.tsxsrc/components/landing/LandingTestimonials.tsx(new testimonials section)next/dynamic({ ssr: false })withanimate-pulseskeleton placeholdersNewsletterFormimport frompage.tsxCloses #272 — FE-144: Bulk check-in upload for offline verification
src/features/verification/page.tsxPOST /api/tickets/check-inin parallelCloses #271 — FE-143: Tests for ticket check-in and verification utilities
src/__tests__/ticketCheckInVerification.test.tswith 13 testsmarkTicketUsed: success, already-used (409), network errorisTicketUsed: returns true, returns false, non-ok responseverifyTicket: valid token, expired token, revoked token, service unavailablecheckInTicket: success, already-used, server errornpm test)Testing