Skip to content

Rubric has fine-grained specs, with no partial credit - #1

Open
justinhaaheim wants to merge 5 commits into
masterfrom
rubric-no-partial-points
Open

Rubric has fine-grained specs, with no partial credit#1
justinhaaheim wants to merge 5 commits into
masterfrom
rubric-no-partial-points

Conversation

@justinhaaheim

Copy link
Copy Markdown
Contributor

In order to make our interviews as consistent and objective as possible, the scoring rubric for this test no longer includes partial credit. Each spec/requirement has been broken down into the smallest unit and given a point value.

@justinhaaheim

Copy link
Copy Markdown
Contributor Author

Note: I also think that the current challenge has too much content and is calibrated too tough. I recommend removing the third section (redirect to previous page after sign-in) entirely.

@bonnie

bonnie commented Jan 27, 2018

Copy link
Copy Markdown

This looks great, @justinhaaheim -- huge improvement. I especially like the clarity and simplicity of the db test specs. Some comments below:

  1. This could be clarified:
[ ] __15:__ When the user clicks submit, the rant is added to the page.

to

[ ] __15:__ When the user clicks submit, the title and body for the new rant are added to the page.
  1. Similarly
[ ] __10:__ If the HTTP request or database insert fails, the rant is not added to the page.

to

[ ] __10:__ If the HTTP request or database insert fails, the title and body for the new rant are not added to the page.
  1. This:
[ ] __10:__ A user cannot add rants for any other users, including by editing client-side HTML or JavaScript.

should specify what happens if a user tries to add a rant by any other users.

  1. This is unnecessarily wordy:
[ ] __10:__ When the user attempts to access a page that requires sign-in and is not signed in, the system captures the URL they were attempting to access and redirects to `/sign-in`.

Consider changing to:

[ ] __10:__ When the user attempts to access a page that requires sign-in and is not signed in, the system redirects to `/sign-in`.
  1. Clarify:
 [] __10:__ If the user navigated directly to `/sign-in`, they are redirected to the restaurants page (`/restaurants`).

to

 [] __10:__ If the user navigated directly to `/sign-in`, they are redirected to the restaurants page (`/restaurants`) after successful sign-in.

@punitrathore

Copy link
Copy Markdown
Contributor

Looks good to me. Just a nitpick, the total number of points for the first part went up by 5 points. Was 70 earlier, and is now 75. (Not that it makes a major difference)

@justinhaaheim

Copy link
Copy Markdown
Contributor Author

@flyrightsister I took your suggestions. See the most recent commit.

@punitrathore I adjusted the point totals. Testing is now roughly 20%, url redirect is roughly 33%, adding rants is roughly 47%, which is about the same as it was before the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants