Fix issue 323 prototypes tests#325
Open
Felsilva15 wants to merge 3 commits intoLearningTypeScript:mainfrom
Open
Fix issue 323 prototypes tests#325Felsilva15 wants to merge 3 commits intoLearningTypeScript:mainfrom
Felsilva15 wants to merge 3 commits intoLearningTypeScript:mainfrom
Conversation
test(the-typeinator): add index.test.js for syntactic-sugar step
- Use jest.fn() instead of manual array for cleaner assertions - Add missing machine objects to fix test failures - Support TEST_SOLUTIONS environment variable
- Add comprehensive test suite for Robot and Humanoid classes - Implement conditional test skipping for educational workflow - Tests skip when index.js is empty (learner mode) - Tests run with TEST_SOLUTIONS=true (validation mode) - Cover class construction, inheritance, and method functionality - Include console.log mocking for announce/charge/move methods - Validate power management and error handling logic
Contributor
By the way @Felsilva15, have you been writing these PR descriptions -or the PRs themselves?- largely with AI? They're very verbose. There's no need to explicitly call out every single detail in them, or end with this kind of high-level overview. 🙂 |
3 tasks
JoshuaKGoldberg
requested changes
Sep 9, 2025
Contributor
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looks like this also has the step 1 change from #321? See: #321 (comment)
JoshuaKGoldberg
added
the
status: waiting for author
|
@JoshuaKGoldberg - yes, I am using AI for the description since it has a template, and I thought it had to follow a specific format every single time. I’ll keep this in mind for the next PRs; I really appreciate the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Add comprehensive test suite for the prototypes-to-classes exercise in the-typeinator project.
This PR adds the missing
index.test.jsfile that was requested in issue #323. The test file includes:index.jsis empty (learner mode), allowing students to start with clean filesTEST_SOLUTIONS=trueis set (validation mode)The implementation follows the same pattern established in other test files in the repository, ensuring consistency with the educational workflow.