WIP : Dev swap - #26
Closed
sportron-ledger wants to merge 7 commits into
Closed
sportron-ledger wants to merge 7 commits into
sportron-ledger wants to merge 7 commits into
Conversation
fix: device getting stuck on the loading transaction screen when no f…
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /// Convert params->amount into uint64_t | ||
| u128_t raw_amount = {0}; | ||
| if (!swap_str_to_u128((const char *) params->amount, params->amount_length, &raw_amount)) { |
| PRINTF("Validated ticker: %s, decimals: %d\n", swap_validated.ticker, swap_validated.decimals); | ||
|
|
||
| // Save amount | ||
| if (!swap_str_to_u128( |
| G_context.tx.transfer.token_info->ticker); | ||
|
|
||
| if (G_called_from_swap) { | ||
| review_transaction(swap_check_validity(&G_context.tx.transfer, total_fees)); |
Comment on lines
+35
to
+37
| /*#define HASH_INPUT_MAX_LENGTH (8) | ||
|
|
||
| static field_t hash_input[HASH_INPUT_MAX_LENGTH]; | ||
| static char text_buffer[32]; | ||
| static field_t hash_input[HASH_INPUT_MAX_LENGTH];*/ |
| { | ||
| _Static_assert(HASH_INPUT_MAX_LENGTH >= 4, "hash_input size won't fit"); | ||
| int status = -1; | ||
| //_Static_assert(HASH_INPUT_MAX_LENGTH >= 4, "hash_input size won't fit"); |
| { | ||
| _Static_assert(HASH_INPUT_MAX_LENGTH >= 6, "hash_input size won't fit"); | ||
| int status = -1; | ||
| //_Static_assert(HASH_INPUT_MAX_LENGTH >= 6, "hash_input size won't fit"); |
| static int graph_key_from_view_key(const scalar_t *view_key, field_t *graph_key) | ||
| { | ||
| _Static_assert(HASH_INPUT_MAX_LENGTH >= 7, "hash_input size won't fit"); | ||
| //_Static_assert(HASH_INPUT_MAX_LENGTH >= 7, "hash_input size won't fit"); |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-new-tokens-support #26 +/- ##
==========================================================
+ Coverage 68.58% 68.72% +0.13%
==========================================================
Files 43 44 +1
Lines 5153 5211 +58
Branches 837 850 +13
==========================================================
+ Hits 3534 3581 +47
- Misses 1351 1358 +7
- Partials 268 272 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Code coverage reportPer-file coverage
|
sportron-ledger
force-pushed
the
dev-new-tokens-support
branch
6 times, most recently
from
August 4, 2026 13:24
9af50fb to
ac6e3a4
Compare
Contributor
Author
|
Replaced by #27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
develop