Skip to content

address book + tronify integration + cmake support - #100

Open
mbrousset-ledger wants to merge 12 commits into
developfrom
mbr/address-book
Open

address book + tronify integration + cmake support#100
mbrousset-ledger wants to merge 12 commits into
developfrom
mbr/address-book

Conversation

@mbrousset-ledger

@mbrousset-ledger mbrousset-ledger commented Jul 15, 2026

Copy link
Copy Markdown
  • address book integration
  • migrating nano devices to nbgl
  • rework functional tests to use modern ragger logic
  • functional tests
  • unit tests
  • cmake support

⚠️ Pending release of API_LEVEL_27 app-builder, ragger tests cannot pass in CI. This is expected.
⚠️ cmake support and unit-tests currently depend on unmerged sdk PR : LedgerHQ/ledger-secure-sdk#1687. Meanwhile, Makefile build system remains unchanged.

build instructions

To build with new Cmake build system :

# unit tests
cmake --preset unit-tests
cmake --build --preset unit-tests
ctest --preset unit-tests

# target build
cmake --preset flex
cmake --build --preset flex
python3 -m ledgerblue.runScript --elfFile build/flex/bin/app.elf --fileName build/flex/bin/app.apdu --apdu --scp

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

elf sizes
source = source branch mbr/address-book
target = target branch develop

Device .text source .text target .text delta .bss source .bss target .bss delta max stack size source max stack size target max stack size delta
flex 93582 78217 15365 16433 6680 9753 20420 30176 -9756
nanos2 68689 56396 12293 15288 5540 9748 25664 35412 -9748
apex_p 89756 74903 14853 16433 6680 9753 24516 34272 -9756
stax 93332 77967 15365 16433 6680 9753 20420 30176 -9756
nanox 68689 56140 12549 15304 5564 9740 8192 8192 0

Stack consumption summary

⚠️ This summary is for informative purpose only. It may not give the application actual worst case, for example if the test coverage is low.

Device Worst case (bytes) Remaining stack (bytes) Test
apex_p 2177 22339 test_address_book_cmd.py::test_address_book_simple_tx[apex_p]
flex 2177 18243 test_address_book_cmd.py::test_address_book_simple_tx[flex]
nanosp 2281 23383 test_address_book_cmd.py::test_address_book_simple_tx[nanosp]
nanox 2265 11095 test_address_book_cmd.py::test_address_book_simple_tx[nanox]
stax 2177 18243 test_address_book_cmd.py::test_address_book_simple_tx[stax]

Full details

Comment thread .github/workflows/lint.yml Fixed
Comment thread .github/workflows/python_checks.yml Fixed
@mbrousset-ledger mbrousset-ledger changed the title Mbr/address book address book Jul 17, 2026
@mbrousset-ledger
mbrousset-ledger force-pushed the mbr/address-book branch 5 times, most recently from 4810ba7 to c19af72 Compare July 17, 2026 13:33
@mbrousset-ledger
mbrousset-ledger marked this pull request as ready for review July 17, 2026 13:33
Comment thread .github/workflows/lint.yml
Comment thread tests/conftest.py Outdated
Comment thread tests/pytest.ini Outdated
Comment thread src/addr_book/handle_contacts.c Outdated
Comment thread src/addr_book/handle_identity.c Outdated
Comment thread src/addr_book/handle_ledger_account.c Outdated
@ledger-wiz-cspm-secret-detection

ledger-wiz-cspm-secret-detection Bot commented Aug 6, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total -

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio.

@mbrousset-ledger mbrousset-ledger changed the title address book address book + tronify integration Aug 10, 2026
Comment thread src/handlers/sign.c Fixed
@mbrousset-ledger
mbrousset-ledger force-pushed the mbr/address-book branch 3 times, most recently from 8998484 to f8ff06c Compare August 20, 2026 15:25
Comment on lines +14 to +19
name: Call Ledger unit_test
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_unit_tests.yml@v1
secrets: inherit
with:
test_directory: unit-tests
use_cmake_ut_framework: true
@mbrousset-ledger
mbrousset-ledger force-pushed the mbr/address-book branch 3 times, most recently from 240a8b1 to 4ae2fae Compare August 24, 2026 13:31
@mbrousset-ledger mbrousset-ledger changed the title address book + tronify integration address book + tronify integration + cmake support Aug 24, 2026
@mbrousset-ledger
mbrousset-ledger force-pushed the mbr/address-book branch 2 times, most recently from b5296bc to 5e9c2fc Compare August 28, 2026 10:52
Comment on lines +9 to +13
name: GitHub release using the reusable workflow
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_app_release.yml@v1
if: startsWith(github.ref, 'refs/tags/')
with:
app_ref_name: ${{ github.ref_name }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants