Skip to content

Add a default 1000 user in dockers#217

Open
fbeutin-ledger wants to merge 1 commit intomasterfrom
fbe/create_base_docker_user
Open

Add a default 1000 user in dockers#217
fbeutin-ledger wants to merge 1 commit intomasterfrom
fbe/create_base_docker_user

Conversation

@fbeutin-ledger
Copy link
Copy Markdown
Contributor

@fbeutin-ledger fbeutin-ledger commented Dec 15, 2025

Before:

$> docker run -it ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest
root@eea4e3a49139:/app# whoami
root

After

$> docker run -it ledger-app-builder:local
base_user@22215901ecec:~$ whoami
base_user

This gives the default 1000 user a home dir which enables seamless auto VSCode DevContainer integration

@agrojean-ledger
Copy link
Copy Markdown
Contributor

@fbeutin-ledger no side effect to change the user from root to the base user in some CI workflows or stuff like that ?

@agrojean-ledger
Copy link
Copy Markdown
Contributor

agrojean-ledger commented Dec 29, 2025

@yogh333 do we still need https://github.com/LedgerHQ/ledger-vscode-extension/blob/03ebf1d1a12cf9644657c6a7a0878b8c4407b906/src/containerManager.ts#L10 after this PR is merged ? 🤔

For windows we still need to change the user to root at least I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants