Add a default 1000 user in dockers#217
Open
fbeutin-ledger wants to merge 1 commit intomasterfrom
Open
Conversation
Contributor
|
@fbeutin-ledger no side effect to change the user from root to the base user in some CI workflows or stuff like that ? |
Contributor
|
@yogh333 do we still need https://github.com/LedgerHQ/ledger-vscode-extension/blob/03ebf1d1a12cf9644657c6a7a0878b8c4407b906/src/containerManager.ts#L10 after this PR is merged ? 🤔 For windows we still need to change the user to root at least I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After
This gives the default 1000 user a home dir which enables seamless auto VSCode DevContainer integration