fix: disable pending review gadget when io_new is enabled - #430
Open
ryan-sentz wants to merge 1 commit into
Open
ryan-sentz wants to merge 1 commit into
ryan-sentz wants to merge 1 commit into
Conversation
ryan-sentz
requested review from
tdejoigny-ledger
and removed request for
a team
September 10, 2026 20:13
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Gating the function introduces io_new-only unused-import warnings that will fail CI under cargo clippy -- -D warnings, and there is also a rustdoc code-fence formatting issue in the edited area.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to restore ledger_device_sdk build compatibility when the io_new feature is enabled by disabling the legacy-only display_pending_review UI gadget that depends on the old Comm::next_event<T>() API.
Changes:
- Gate
display_pending_reviewbehind#[cfg(not(feature = "io_new"))]to avoid compiling legacy-IO code whenio_newis enabled.
File summaries
| File | Description |
|---|---|
ledger_device_sdk/src/ui/gadgets.rs |
Disables a legacy-IO-only UI helper when io_new is enabled to prevent build failures. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+72
to
74
| #[cfg(not(feature = "io_new"))] | ||
| pub fn display_pending_review(comm: &mut Comm) { | ||
| clear_screen(); |
| @@ -69,6 +69,7 @@ pub fn clear_screen() { | |||
| /// ... | |||
| /// } | |||
| /// ` | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
display_pending_reviewfunction uses the old comm interface / event type so this won't build withio_newenabled.