Skip to content

Remove limitation for API LEVEL to be used with every device #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlafon-ledger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove limitation for API LEVEL to be used with every device #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ binary = "bin/app_nanosp.hex"
dataSize = 64
```

3. Install with `ledgerctl install app.json`.
3. Install with `ledgerctl install app.toml`.

If you want to force the deletion of the previous version, run the previous command with the `-f` flag.

Expand Down
7 changes: 2 additions & 5 deletions ledgerwallet/manifest_toml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from typing import Optional

from ledgerwallet.manifest import AppManifest, icon_from_file
from ledgerwallet.utils import DeviceNames, get_device_name
from ledgerwallet.utils import get_device_name

if sys.version_info >= (3, 11):
import tomllib
Expand All @@ -30,10 +30,7 @@ def get_application_flags(self, device: str) -> int:
return int(self.dic[device].get("flags", "0"), 16)

def get_api_level(self, device: str) -> Optional[int]:
if (
get_device_name(int(device, 16)) == DeviceNames.LEDGER_NANO_SP.value
and "apiLevel" in self.dic[device]
):
if "apiLevel" in self.dic[device]:
level = self.dic[device]["apiLevel"]
if isinstance(level, int):
return int(level)
Expand Down