Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

taproot address support implemented#144

Open
vsenkiv-ledger wants to merge 1 commit into
LedgerHQ:mainfrom
klm0x3:implement_scan_of_taproot_adresses
Open

taproot address support implemented#144
vsenkiv-ledger wants to merge 1 commit into
LedgerHQ:mainfrom
klm0x3:implement_scan_of_taproot_adresses

Conversation

@vsenkiv-ledger
Copy link
Copy Markdown

@vsenkiv-ledger vsenkiv-ledger commented Oct 11, 2022

The goal of this PR is to implement possibility to scan taproot addresses.
Currently works only for mainnet.

@klm0x3 klm0x3 deleted the implement_scan_of_taproot_adresses branch October 11, 2022 14:23
@klm0x3 klm0x3 restored the implement_scan_of_taproot_adresses branch October 11, 2022 14:37
Copy link
Copy Markdown

@twilgenbus-ledger twilgenbus-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • If it works only for mainnet, what happens when used on testnet?

Comment thread src/actions/deriveAddresses.ts
Comment thread package.json
Comment thread src/actions/deriveAddresses.ts
@vsenkiv-ledger
Copy link
Copy Markdown
Author

Great work!

  • If it works only for mainnet, what happens when used on testnet?
    no crash, no error is thrown, but for test I used testnet taproot xpub which has no transactions, so I'm just getting 0 balance and 0 transactions what it expected but for complete test taproot testnet account with transactions is neeeded, creating taproot transactions would took more time and my final goal is to implement cardano scan, so at the moment taproot mainnet confirmed, testnet - not tested fully, just that no errors.

Copy link
Copy Markdown

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavlogs
Copy link
Copy Markdown
Contributor

pavlogs commented Dec 1, 2022

To pass all checks you should rebase on main and update dependencies if needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants