Add +html.tsx to Expo example for better universal support#421
Add +html.tsx to Expo example for better universal support#421trcoffman wants to merge 1 commit intoLegendApp:webfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba797a5264
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <meta | ||
| content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no, shrink-to-fit=no" | ||
| name="viewport" |
There was a problem hiding this comment.
On mobile web this root HTML is applied to every route, so maximum-scale=1, user-scalable=no makes all of the demo screens with TextInput (chat-example, accurate-scrollto, countries, etc.) non-zoomable in Safari/Chrome. That is an accessibility regression for low-vision users, and Expo Router’s documented +html.tsx template does not include those flags, so the example becomes less usable on phones rather than more universally supported.
Useful? React with 👍 / 👎.
1 participant
Many people using this library use expo-web so it's good to make sure the example app works well with expo-web.