Skip to content

add rubocop-legion plugin #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Esity merged 1 commit into from
Mar 30, 2026
Merged

add rubocop-legion plugin #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
ci:
uses: LegionIO/.github/.github/workflows/ci.yml@main

lint:
uses: LegionIO/.github/.github/workflows/lint-patterns.yml@main
excluded-files:
uses: LegionIO/.github/.github/workflows/excluded-files.yml@main

security:
uses: LegionIO/.github/.github/workflows/security-scan.yml@main
Expand All @@ -27,7 +27,7 @@ jobs:
uses: LegionIO/.github/.github/workflows/stale.yml@main

release:
needs: [ci, lint]
needs: [ci, excluded-files]
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
uses: LegionIO/.github/.github/workflows/release.yml@main
secrets:
Expand Down
55 changes: 2 additions & 53 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,53 +1,2 @@
AllCops:
TargetRubyVersion: 3.4
NewCops: enable
SuggestExtensions: false

Layout/LineLength:
Max: 160

Layout/SpaceAroundEqualsInParameterDefault:
EnforcedStyle: space

Layout/HashAlignment:
EnforcedHashRocketStyle: table
EnforcedColonStyle: table

Metrics/MethodLength:
Max: 50

Metrics/ClassLength:
Max: 1500

Metrics/ModuleLength:
Max: 1500

Metrics/BlockLength:
Max: 40
Exclude:
- 'spec/**/*'

Metrics/ParameterLists:
Max: 8

Metrics/AbcSize:
Max: 60

Metrics/CyclomaticComplexity:
Max: 15

Metrics/PerceivedComplexity:
Max: 17

Style/Documentation:
Enabled: false

Style/SymbolArray:
Enabled: true

Style/FrozenStringLiteralComment:
Enabled: true
EnforcedStyle: always

Naming/FileName:
Enabled: false
inherit_gem:
rubocop-legion: config/lex.yml
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## [0.2.5] - 2026-03-30

### Changed
- update to rubocop-legion 0.1.7, resolve all offenses

## [0.2.4] - 2026-03-28

### Added
Expand Down
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ group :test do
gem 'rspec'
gem 'rspec_junit_formatter'
gem 'rubocop'
gem 'rubocop-legion', '~> 0.1'
gem 'simplecov'
end
2 changes: 1 addition & 1 deletion lib/legion/extensions/github.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
module Legion
module Extensions
module Github
extend Legion::Extensions::Core if Legion::Extensions.const_defined? :Core
extend Legion::Extensions::Core if Legion::Extensions.const_defined? :Core, false
end
end
end
6 changes: 3 additions & 3 deletions lib/legion/extensions/github/runners/branches.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ def create_branch(owner:, repo:, branch:, from_ref: 'main', **)

{ success: true, ref: create_response.body['ref'], sha: sha }
rescue StandardError => e
log.warn(e.message) if respond_to?(:log, true)
log.warn(e.message)
{ success: false, error: e.message }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/comments.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ def delete_comment(owner:, repo:, comment_id:, **)
{ result: response.status == 204 }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/commits.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ def compare_commits(owner:, repo:, base:, head:, per_page: 30, page: 1, **)
{ result: response.body }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
6 changes: 3 additions & 3 deletions lib/legion/extensions/github/runners/contents.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ def commit_files(owner:, repo:, branch:, files:, message:, **)

{ success: true, commit_sha: new_commit.body['sha'], tree_sha: new_tree.body['sha'] }
rescue StandardError => e
log.warn(e.message) if respond_to?(:log, true)
log.warn(e.message)
{ success: false, error: e.message }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/gists.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ def delete_gist(gist_id:, **)
{ result: response.status == 204 }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/issues.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ def create_issue_comment(owner:, repo:, issue_number:, body:, **)
{ result: response.body }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/labels.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ def remove_label_from_issue(owner:, repo:, issue_number:, name:, **)
{ result: response.status == 204 }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/organizations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ def list_org_members(org:, per_page: 30, page: 1, **)
{ result: response.body }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/pull_requests.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ def create_review(owner:, repo:, pull_number:, body:, comments: [], event: 'COMM
{ result: response.body }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/repositories.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ def list_tags(owner:, repo:, per_page: 30, page: 1, **)
{ result: response.body }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/search.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def search_code(query:, sort: nil, order: 'desc', per_page: 30, page: 1, **)
{ result: response.body }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/legion/extensions/github/runners/users.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ def list_following(username:, per_page: 30, page: 1, **)
{ result: response.body }
end

include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers) &&
Legion::Extensions::Helpers.const_defined?(:Lex)
include Legion::Extensions::Helpers::Lex if Legion::Extensions.const_defined?(:Helpers, false) &&
Legion::Extensions::Helpers.const_defined?(:Lex, false)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/legion/extensions/github/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module Legion
module Extensions
module Github
VERSION = '0.2.4'
VERSION = '0.2.5'
end
end
end
Loading