Add to the api mock a fake method that will load the evaluation based on the id#146
Open
jecaestevez wants to merge 3 commits intoLemoncode:masterfrom
jecaestevez:master
Open
Add to the api mock a fake method that will load the evaluation based on the id#146jecaestevez wants to merge 3 commits intoLemoncode:masterfrom jecaestevez:master
jecaestevez wants to merge 3 commits intoLemoncode:masterfrom
jecaestevez:master
Conversation
nasdan
reviewed
Jun 29, 2017
src/rest-api/trainer/trainerApi.ts
Outdated
| public getExerciseEvaluationById(id: number): Promise<ExerciseEvaluation> { | ||
| let evaluation: ExerciseEvaluation; | ||
|
|
||
| const evaluationData = exerciseEvaluationMockedData.filter((evaluationItem) => { |
Member
There was a problem hiding this comment.
Instead of use filter you can use find to get the first item that satisfies the condition
Member
RosanaRufer
approved these changes
Jul 1, 2017
| it('returns expected Exercise Evaluation by id equals 1', sinon.test((done) => { | ||
| // Arrange | ||
| const sinon: sinon.SinonStatic = this; | ||
|
|
There was a problem hiding this comment.
Are these line breaks between constant declarations a coding guideline? I would remove them...
Member
There was a problem hiding this comment.
The linter rule we are using forbids adding more than two consecutive blank lines, in this case I would put together all the const statements
Member
|
Hi @jecaestevez when do you think you can apply the feedback from the pull? I think it would be a good idea to get this branch fine merge it, and then let you start working on the next subcase. What do you think? |
Collaborator
Author
|
Today I'll do a pull requested with the code review and other sub cases.
…On Sun, 9 Jul 2017 at 10:17, Braulio Diez ***@***.***> wrote:
Hi @jecaestevez <https://github.com/jecaestevez> when do you think you
can apply the feedback from the pull? I think it would be a good idea to
get this branch fine merge it, and then let you start working on the next
subcase. What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABv42N-OnQ-sqnbmY3LNQxpIqfn9KNPlks5sMIx7gaJpZM4OInA0>
.
|
Collaborator
Author
|
I've uploaded the code review changes and other small subcase |
…to filter and formatting styles. Added Save exercise evaluation method. Fixed a type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.