Address review comments: fix duplicate text and typo#1190
Merged
LetMeFly666 merged 3 commits into3346from Oct 30, 2025
Merged
Conversation
Owner
|
@copilot do not change this： Fix signed/unsigned comparison in Codes/3346-maximum-frequency-of-an-element-after-performing-operations-i.cpp line 24 |
Co-authored-by: LetMeFly666 <56995506+LetMeFly666@users.noreply.github.com>
Owner
|
有点慢嗷 也还行 |
LetMeFly666
reviewed
Oct 30, 2025
| l++; | ||
| } | ||
| while (r < nums.size() && nums[r] - target <= k) { | ||
| while (r < static_cast<int>(nums.size()) && nums[r] - target <= k) { |
Contributor
Author
There was a problem hiding this comment.
Reverted the static_cast change in commit 4b411de. The C++ file is now back to using r < nums.size() without the cast.
Copilot
AI
changed the title
[WIP] Update code and solution for problem 3346
Address review comments: fix duplicate text, signed comparison, and typo
Oct 30, 2025
Co-authored-by: LetMeFly666 <56995506+LetMeFly666@users.noreply.github.com>
Copilot
AI
changed the title
Address review comments: fix duplicate text, signed comparison, and typo
Address review comments: fix duplicate text and typo
Oct 30, 2025
LetMeFly666
approved these changes
Oct 30, 2025
LetMeFly666
added a commit
that referenced
this pull request
Oct 30, 2025
* codes: huawei笔试 cpp 环境没配好 Signed-off-by: LetMeFly666 <814114971@qq.com> * refactor: codes should in Codes Signed-off-by: LetMeFly666 <814114971@qq.com> * feat: 毕设月报+京东笔试 Signed-off-by: LetMeFly666 <814114971@qq.com> * feat: debug cpp on mac M-series using VsCode internal Signed-off-by: LetMeFly666 <814114971@qq.com> * word: en+jp today * 3346: WA.cpp (#1179) * 3346: WA.cpp (#1179) - target不能只nums[i] * 3346: AC.cpp+py+go+java | CE.rust (#1179) cpp - AC,76.60%,38.28% py - AC,89.80%,80.81% go - AC,85.42%,48.84% java - AC,81.31%,4.99% * 3346: AC.rust (#1179) - AC,75.63%,42.86% * update: 添加问题“3346.执行操作后元素的最高频率I”的代码和题解 (#1188) Signed-off-by: LetMeFly666 <814114971@qq.com> * Address review comments: fix duplicate text and typo (#1190) * Initial plan * Fix review comments: remove duplicate, fix comparison, fix spelling Co-authored-by: LetMeFly666 <56995506+LetMeFly666@users.noreply.github.com> * Revert C++ signed/unsigned comparison fix as requested Co-authored-by: LetMeFly666 <56995506+LetMeFly666@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: LetMeFly666 <56995506+LetMeFly666@users.noreply.github.com> * docs: record (#1188) --------- Signed-off-by: LetMeFly666 <814114971@qq.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves two code review findings from the previous PR:
The C++ signed/unsigned comparison warning was initially addressed but has been reverted per maintainer feedback.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.