Repository navigation
Conversation
User-initiated delete already dropped the DB row after a failed S3 unlink. The code-env / local-disk pass still aborted, so a 403 from the extra store left the row in place. Fixes LibreChat-AI#15971
codegraph-librechat
Bot
added
🗺️ File Storage
codegraph-librechat
Bot
added
🗺️ Platform Security
Contributor
|
Thank you, @gyanu2507, for identifying and testing the secondary-storage 403 path. Closing in favor of canonical #17228: failed secondary cleanup retains primary bytes and metadata for safe retry rather than swallowing the failure and dropping the record. Its regression coverage includes secondary 401/403/500 failures. The broader manual-delete backoff request in #15971 remains separate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15971
User-initiated delete already dropped the DB row after a failed S3 unlink (the retention sweep in #15608 taught that path some backoff). The code-env / local-disk pass still aborted, so a 403 from the extra store left the row in place and the UI retried forever.
The secondary delete is now non-fatal: log it, keep going, let the DB row drop. Test covers a 403 from the extra store.