🥧 refactor: Show Failed Call Fractions and Preview Age - #16468
Conversation
|
Review handoff for head |
|
Review handoff for head |
|
Review handoff for head |
|
Review handoff for head |
|
Review handoff for head |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Collapsed activity phases and tool groups say only
1 failed, so a reader cannot tell whether one of two calls failed or every call failed. The phase preview also lacks a failure age even when a run-step closure has a reliable timestamp. An expanded live phase could also show the same failure pill again beside a nested tool group. This change showsfailed/total failedin both badges and accessible headers, gives the parent phase sole ownership of its pill while preserving live group expansion, and displays the first failed call's localized relative age in its collapsed preview. Older parts without a close timestamp keep the preview without a fabricated time.The color-gradient idea is intentionally deferred: the shared theme exposes warning and error roles, but no intermediate orange role. Adding an untested interpolation here would risk contrast and high-contrast themes.
How it works
Type of change
Testing
Tested environments/configuration: Node.js 24, isolated LibreChat worktree. Local installed dependencies are incomplete, so CI is the source of full Jest/typecheck results.
Automated tests: Added/updated focused phase, live nested-group integration, group, failure-line, SSE-close and timestamp-validation tests. Parsed changed TypeScript/JavaScript with the local TypeScript compiler and smoke-tested the close-time helper. Ran targeted import sort, Prettier,
git diff --check, and unused-i18n-key checks. Attempted focused Jest tests,tsc --noEmitin client, packages/api and packages/data-provider, andnpm run buildin packages/data-provider; these cannot complete locally because the installed node_modules lack Jest dependencies, @types entries, and tsdown. The attempted local static-checks passed Prettier and import sorting but could not run ESLint and circular dependency checks for the same reason. CI will rerun with installed dependencies.