Repository navigation
🗂️ feat: Record Lane Git State and Serve Conversation Pull Requests #16793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
013c597
2415224
d831aa3
c305a0c
ab87dd9
15cdb7a
517f4ec
d35c5cf
30f3ce8
062c52f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,9 @@ const { | |
| createBackgroundTaskIndexHandler, | ||
| createBackgroundTaskCancelHandler, | ||
| createBackgroundTaskPolicyMiddleware, | ||
| createConversationPullRequestHandler, | ||
| createGitHubPullRequestSource, | ||
| createPullRequestLookup, | ||
| backgroundTaskRegistry, | ||
| createSubagentThreadViewHandler, | ||
| createGeneratedTitleHandler, | ||
|
|
@@ -167,6 +170,12 @@ const backgroundTaskIndexHandler = createBackgroundTaskIndexHandler({ | |
| const backgroundTaskCancelHandler = createBackgroundTaskCancelHandler({ | ||
| registry: backgroundTaskRegistry, | ||
| }); | ||
| const conversationPullRequestHandler = createConversationPullRequestHandler({ | ||
| getConvoLaneGit: db.getConvoLaneGit, | ||
| getAppConfig, | ||
| lookup: createPullRequestLookup({ source: createGitHubPullRequestSource({ fetchFn: fetch }) }), | ||
| env: process.env, | ||
| }); | ||
| router.use(requireJwtAuth); | ||
|
|
||
| const isValidProjectFilter = (projectId) => | ||
|
|
@@ -239,6 +248,7 @@ router.post( | |
| subagentControlHandler, | ||
| ); | ||
| router.get('/:parentConversationId/subagents', parentSubagentIndexHandler); | ||
| router.get('/:conversationId/pull-request', conversationPullRequestHandler); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Enabling AGENTS.md reference: AGENTS.md:L49-L52 Useful? React with 👍 / 👎. |
||
| router.get('/:conversationId/background-tasks', backgroundTaskPolicy, backgroundTaskIndexHandler); | ||
| router.post( | ||
| '/:conversationId/background-tasks/cancel', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This registers the backend capability, but a repo-wide search of
clientandpackages/clientfinds no caller ofgetConversationPullRequest/conversationPullRequestand no pull-request header rendering. Consequently enabling the documented setting cannot show anything to users; add the header query and its loading, empty, success, and failure states before exposing the route.AGENTS.md reference: AGENTS.md:L49-L52
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is the second of three stacked ones on purpose. The header consumer is #16794, which is based on this branch: it adds the query hook, the chip and card, and the loading, empty, success and failure states, and uses getConversationPullRequest. The route is inert until endpoints.agents.pullRequests is enabled, which defaults to off, so nothing is exposed before the consumer lands. Leaving this open for you to decide whether the stack is acceptable or should be one PR.