Skip to content

project inspection timeout can publish unread metadata as null #241

Description

@danny-avila

The local-project inspection added by #221 can publish timeout results as if Git metadata were genuinely absent.

After top-level admission, remote, branch, and head are read without another deadline check. If the budget expires at the beginning of git(), it returns null without marking the inventory incomplete. A timed-out repository can therefore appear to have no origin, a detached HEAD, or an unborn branch even though those values were never read.

Found while syncing #221 into ClickHouse/ai: https://github.com/ClickHouse/ai/pull/3849#discussion_r4033110191

Suggested direction: propagate timeout/incomplete state from each metadata read and add a test where the budget expires between admission and Git metadata collection.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions