Skip to content

fix: stop the CDN caching markdown-negotiated docs pages as HTML #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny-avila merged 1 commit into from
Jul 23, 2026
Merged

fix: stop the CDN caching markdown-negotiated docs pages as HTML #701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,15 @@ const OG_VERSION = computeOgVersion()
* `private, no-store` so the CDN never caches it and therefore can never serve
* one as a document. A cached document occasionally returned to an RSC request
* just makes Next fall back to a full navigation, which is harmless.
*
* The same collision applies to the markdown content negotiation in proxy.ts
* (`isMarkdownPreferred`): a `/docs/*` request with `Accept: text/markdown`
* (LLM/agent tooling) gets rewritten to the raw-markdown response, but that
* response shares its cache key with the HTML document since Cloudflare
* ignores `Vary` here too. Whichever one a given edge PoP sees first for a URL
* gets cached for it and served to everyone else hitting that PoP, including
* browsers, until the entry expires. Mark those responses `private, no-store`
* for the same reason as the RSC flight payload.
*/
const SHARED_CDN_CACHE = 'public, s-maxage=86400, stale-while-revalidate=604800'
const cdnCacheHeaders = [
Expand All @@ -110,6 +119,11 @@ const cdnCacheHeaders = [
has: [{ type: 'header', key: 'RSC' }],
headers: [{ key: 'Cache-Control', value: 'private, no-store' }],
},
{
source,
has: [{ type: 'header', key: 'accept', value: '.*text/markdown.*' }],
headers: [{ key: 'Cache-Control', value: 'private, no-store' }],
},
])

/** @type {import('next').NextConfig} */
Expand Down
Loading