Add wasmJs target and support#73
Conversation
|
Hey, thanks for the contribution! Looks like actions/upload-artifact#691 broke the pipeline. Could you switch to |
|
Sure thing, sorry haven't been able to get to this yet. Will try again this week |
Updates include: - Gradle updated to use libs.version.toml for consistency with gradle standards - Removed NPM publish plugin as it is no longer maintained and is incompatible with kotlin wasm - Removed JsExport annotations as they are not compatible with wasm (which has different export restrictions). - Updated some dependencies
|
I know I've made some changes that may need rectifying, but now the build works correctly I wanted to see if tests pass in the pipeline. |
You can tell that I don't use github very often :D I pushed your changes so the pipeline runs with the secrets: #75 |
|
I was just looking to work on bumping versions to fix the ktor compatiblity issues I'm also experience, but the work is already done here! Any way we can get some movement on this 🙏 |
|
https://github.com/Liftric/cognito-idp/pull/75/checks fails during As a linux user I can't debug it and no apple user at our place has time for it right now. |
|
It's probably related to profile provisioning. Although I am quite new on iOS. Could help @Ingwersaft ? |
|
Main Causes and Solutions The error 0xe800801c (No code signature found) means the app binary is not correctly signed. All iOS apps must be signed with a valid certificate and provisioning profile. Possible Reasons:
How to Fix:
If using CI/CD or external tools
|
|
Also keen for this change 🙏 Is this the wrong thread to be debugging iOS build issues in though? The issue is for adding |
|
@chris-hatton-tipmi I believe that ktor 3+ is the main root change, wasm support is an extra |
|
@Khartris did the migration to modern versions. If you are still interested in bringing this to life, I would recommend to rebranch from the current master after #76 was merged to enable |
|
Noted, thanks. I'll take a look and see if I can get that sorted. Appreciate the dependency update being completed already. |
|
@EpicSquid btw huge thanks for tackling this! |
|
New PR submitted with the updated changes. Let me know if you need anything else: #78 |
Using Ktor 3.x and Kotlin 2.0 I've added a wasmJs target for publishing so it can be used fully cross platform.