chore: bump versions#14
Conversation
- Remove AI index line from README.md - Delete keypair.json from create-token-account program - Simplify test println statements to only output transaction signature The transaction signature provides all necessary information for verification and is more useful than verbose descriptive text.
- Remove all TypeScript test files (tests/*.ts) - Remove package.json and tsconfig.json - Remove .claude/settings.json and BURN_ARCHITECTURE.md - Add .gitignore for node_modules, target, TS files - Update Anchor.toml test script to use cargo test-sbf Rust integration tests remain in programs/*/tests/test.rs
tilo-14
force-pushed
the
streaming-tokens
branch
from
ed6e295 to
7b61402
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| "create-interface-pda:action": "tsx actions/create-interface-pda.ts", | ||
| "create-interface-pda:instruction": "tsx instructions/create-interface-pda.ts", |
There was a problem hiding this comment.
🟡 Package.json scripts reference non-existent files
The npm scripts create-interface-pda:action and create-interface-pda:instruction reference files that don't exist, causing the scripts to fail when run.
Click to expand
Details
The package.json defines scripts:
"create-interface-pda:action": "tsx actions/create-interface-pda.ts",
"create-interface-pda:instruction": "tsx instructions/create-interface-pda.ts"But the actual files in the filesystem are named create-spl-interface.ts:
actions/create-spl-interface.tsinstructions/create-spl-interface.ts
Actual behavior: Running npm run create-interface-pda:action will fail with a file not found error.
Expected behavior: The script names should match the actual file names.
Impact: Users following the package.json scripts will encounter errors when trying to run these commands.
Recommendation: Rename the scripts to match the actual file names:
"create-spl-interface:action": "tsx actions/create-spl-interface.ts",
"create-spl-interface:instruction": "tsx instructions/create-spl-interface.ts"
Was this helpful? React with 👍 or 👎 to provide feedback.
| .unwrap(); | ||
|
|
||
| for ix in &msg.instructions { | ||
| let prog_key = &msg.account_keys[ix.program_id_index as usize]; |
There was a problem hiding this comment.
🔴 Potential index out of bounds panic when accessing account_keys
The code accesses msg.account_keys[ix.program_id_index as usize] without bounds checking, which can cause a panic if program_id_index exceeds the length of account_keys.
Click to expand
Details
In toolkits/streaming-tokens/src/main.rs:148:
let prog_key = &msg.account_keys[ix.program_id_index as usize];If the stream delivers malformed transaction data where program_id_index is greater than or equal to account_keys.len(), the code will panic with an index out of bounds error.
Actual behavior: Panic occurs if program_id_index >= account_keys.len().
Expected behavior: The code should handle potentially invalid index gracefully, either by bounds-checking or using .get() with proper error handling.
Impact: A malformed transaction in the stream can crash the entire streaming application.
Recommendation: Use .get() with bounds checking:
let Some(prog_key) = msg.account_keys.get(ix.program_id_index as usize) else {
continue;
};
Was this helpful? React with 👍 or 👎 to provide feedback.
Belongs in a separate PR.
* feat: add anchor program examples for compressed tokens * fix: address PR #9 review comments - Remove AI index line from README.md - Delete keypair.json from create-token-account program - Simplify test println statements to only output transaction signature The transaction signature provides all necessary information for verification and is more useful than verbose descriptive text. * ts tests1 * chore: remove TypeScript tests and add .gitignore - Remove all TypeScript test files (tests/*.ts) - Remove package.json and tsconfig.json - Remove .claude/settings.json and BURN_ARCHITECTURE.md - Add .gitignore for node_modules, target, TS files - Update Anchor.toml test script to use cargo test-sbf Rust integration tests remain in programs/*/tests/test.rs * must still cleanup * add metadata * add macros * rm log * add macro sdk separation * reorder * fixes tests * first final * rename and bug fix * anchor * fix: remove stale macro-basics refs, clean gitignore * latest * chore: bump versions * add interface * update * clean up * fix laserstream * fix streaming tokens * remove program-examples from streaming-tokens branch Belongs in a separate PR. --------- Co-authored-by: tilo-14 <tilo@luminouslabs.com>
1 participant
Summary
0.23.0-beta.3(matches devnet v2.2.0 programs)light-token-interface 0.3.0,light-compressed-account 0.9.0from crates.io