chore: use 'just' instead of 'npx nx'#2196
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughReplaces Nx-based build/test scripts with Just-based workflows: adds per-package Justfiles (forester, programs, program-libs, sdk-libs, prover/server), removes Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CLAUDE.md (1)
1-75: Add required CLAUDE.md sections (Summary, Used in, Navigation, Source Code Structure).This file is missing the mandatory sections for
**/CLAUDE.md, which makes it non-compliant with project documentation standards. Please add them near the top. As per coding guidelines, ...✍️ Minimal template
+# Summary +- … +- … + +# Used in +- … + +# Navigation +- … + +# Source Code Structure +- …
ananas-block
approved these changes
Jan 21, 2026
Contributor
ananas-block
left a comment
ananas-block
left a comment
There was a problem hiding this comment.
nice I like it, just 2 comments, but it seems like that command is not used in ci anyway
sergeytimoshin
force-pushed
the
sergey/just
branch
from
be75ca9 to
1522b4b
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@program-libs/justfile`:
- Line 39: The test invocation in the justfile uses an incorrect `--test` flag
passed to the test binary; change the command so the test filter is passed
directly to the test runner (remove the extra `--test` token) — i.e., keep the
cargo-level separator `--` and pass `test_simulate_transactions` as the filter
so the invocation becomes RUST_LOG=... cargo test -p batched-merkle-tree-test --
test_simulate_transactions; update the line containing that command in the
justfile accordingly.
In `@prover/server/justfile`:
- Around line 68-70: The extract-circuit target currently calls ./light-prover
directly and can fail if the binary doesn't exist; update the justfile so the
extract-circuit recipe depends on the build-binary target (i.e., declare
extract-circuit to depend on build-binary) so that build-binary runs first and
produces ./light-prover before extract-circuit executes; reference the
extract-circuit target and the build-binary target when making this change.
41e16ac to
965884e
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@prover/server/justfile`:
- Around line 42-55: Add a short explanatory comment above the test-integration
(and/or test) target clarifying why test-full is excluded: note that test-full
has a much longer timeout (test-full target with 120m timeout) and is
intentionally omitted from test-integration and test to avoid extremely slow CI
runs, but can be run manually via the test-full target for exhaustive testing;
update the justfile near the test-full, test-integration, and test targets to
include this one-line rationale.
- Around line 57-64: The justfile uses a hardcoded Elan path for lake in the
lean-build target; update lean-build to invoke lake from PATH (replace
"~/.elan/bin/lake" with "lake") so it matches the documented setup, keeping the
existing commands (cd formal-verification && lake exe cache get && lake build)
and leaving the extract-circuit and verify targets (extract-circuit:
build-binary and verify: extract-circuit lean-build) unchanged.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@programs/justfile`:
- Around line 12-13: The build target build-compressed-token-small is changing
into the wrong directory (compressed-token/) which is not a Cargo package;
update the target to cd into the actual crate directory compressed-token/program
before running cargo build-sbf so the cpi-without-program-ids feature (defined
in compressed-token/program/Cargo.toml) is available; locate the
build-compressed-token-small target in the justfile and replace the cd path to
compressed-token/program to match the other compressed-token build target.
In `@sdk-libs/justfile`:
- Around line 6-15: The test recipe in the Justfile is missing the
light-token-sdk crate; update the "test" target to include running cargo test -p
light-token-sdk and cargo test -p light-token-sdk --all-features alongside the
existing crate tests (e.g., the other cargo test -p ... lines) so the SDK
coverage matches the pattern used for light-token and other core SDK crates.
41e16ac to
b93cf05
Compare
…ld-cli dependency
sergeytimoshin
force-pushed
the
sergey/just
branch
from
b93cf05 to
a93bfa3
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@CLAUDE.md`:
- Around line 139-143: Update the incorrect Justfile command examples in
CLAUDE.md: replace "just build-cli" with "just cli::build", "just
test-stateless-js" with "just js::test-stateless", keep "just
js::test-compressed-token" as-is, and replace "just test-cli" with "just
cli::test"; optionally mention the root-level aggregates "just build" and "just
test" as alternatives that include the cli and js targets.
In `@forester/justfile`:
- Around line 3-8: Add a default RUST_BACKTRACE export to the justfile so tests
get backtraces by default: update the exports block (where TEST_MODE,
TEST_V1_STATE, TEST_V2_STATE, TEST_V1_ADDRESS, TEST_V2_ADDRESS are set) to
include RUST_BACKTRACE using the same env_var_or_default helper, e.g. export
RUST_BACKTRACE := env_var_or_default("RUST_BACKTRACE", "1"), so local CI and dev
runs produce useful backtraces for debugging.
♻️ Duplicate comments (1)
sdk-libs/justfile (1)
6-17: Check whetherlight-token-sdkstill needs coverage in the test target.If the workspace still contains a
light-token-sdkcrate, it should likely be exercised alongside the other SDK libs here. Please confirm its presence and add tests if applicable.#!/bin/bash # Check whether light-token-sdk exists as a workspace package rg -n 'name\s*=\s*"light-token-sdk"' -g 'Cargo.toml'➕ Proposed addition (if the crate exists)
test: cargo test -p light-sdk-macros cargo test -p light-sdk-macros --all-features cargo test -p light-sdk cargo test -p light-sdk --all-features cargo test -p light-program-test cargo test -p light-client cargo test -p light-sparse-merkle-tree cargo test -p light-token-types + cargo test -p light-token-sdk + cargo test -p light-token-sdk --all-features cargo test -p light-token --all-features cargo test -p light-token-client cargo test -p light-token-client --all-features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.