feat: add surfpool auto-download and enable surfpool for all tests#2227
Merged
Conversation
Add auto-download of surfpool binary to Light CLI following the prover binary pattern. The CLI now downloads surfpool from GitHub releases to ~/.config/light/bin/surfpool when --use-surfpool is used. Also set use_surfpool: true as the default in LightValidatorConfig and in all explicit test configurations across the repo.
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (5)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Forward upgradeable programs to surfpool via --upgradeable-program flag instead of --bpf-program, enabling proper programdata account creation - Add async warp_to_slot to LightClient using reqwest for surfpool's surfnet_timeTravel RPC method - Update forester tests to use async warp_to_slot - Add local surfpool binary discovery in ensureSurfpoolBinary for development
b1d53b3 to
f64b7df
Compare
Check installed surfpool version before use. If the version doesn't match the expected SURFPOOL_VERSION, re-download from the release. Also update README example with use_surfpool field.
Prevents surfpool from trying to start its explorer/studio web UI during tests, avoiding "Address already in use" errors.
Helps debug photon/surfpool crashes on CI by printing the log file contents instead of only the exit code.
- Skip the test that creates a dummy program .so file (surfpool requires valid ELF binaries for --bpf-program) - Add surfpool to the cleanup function so it is killed between tests
3984447 to
1487e8a
Compare
1487e8a to
78c1118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--no-use-surfpool for solana-test-validator)
v1.0.1-light)
to surfpool CLI args
in tests
spawnBinary() to close inherited FDs and call unref()
fire-and-forget)
TestRpc dependencies because surfpool getTransactionSignatures doesnt return more than 30 signatures
pda, batched state async indexer)