Conversation
Ensure middleware returns immediately after writing a response so next.ServeHTTP is not called for rejected requests, preventing superfluous WriteHeader warnings and unintended downstream execution. Closes LiliannaBruflat83#1 /claim LiliannaBruflat83#1
|
😅 Unfortunately there are no rewards left to claim in this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures middleware returns immediately after writing a response so
next.ServeHTTPis not called for rejected requests, preventingsuperfluous response.WriteHeaderwarnings and unintended downstream execution.Changes
middleware/auth.go: AuthMiddleware writes the 401 response and returns immediately, halting the chain.middleware/auth_test.go: tests verifying the downstream handler is bypassed on rejection and invoked on success.Verification
go vet ./...clean;go test -race -v ./...passes (both tests).Closes #1
/claim #1