Repository navigation
STE-50: Tokens refusals are named from the Tokens ABI - #48
Merged
Merged
Conversation
…red name is not guessed ContractCallError picked the error table from a function-name map that knew registry and escrow only, and fell back to the registry for anything else. The STE-27 rehearsal logged the Tokens gate refusing to licence a DANGEROUS version (#5 NotVerified) as "VersionAlreadyExists (#5, registry)". - TOKENS_ERRORS from contracts/tokens/src/data.rs::TokenError. - REGISTRY_ERRORS gains 10-13, added by STE-44 and never copied. - Entrypoints are listed per contract. A name only one contract exports resolves on its own; a name several export (get_admin, the STE-44 upgrade functions) or an unknown one reports "contract not identified" with each candidate's name, instead of silently borrowing the registry's. - simulate() and invoke() take an optional contract= for the shared names. - Tests read all three tables back from the Rust enums, so a new variant that is not copied fails CI instead of mislabelling a failure in prod. Decision: no guess for shared names. A wrong name sent the operator after a duplicate version when the real cause was the VERIFIED gate; "cannot tell, here are both" costs one extra look and never points the wrong way. E2E: read-only simulate against Tokens v2. mint_license on DANGEROUS release-notes 2.0.0 is NotVerified (#5, tokens); main says VersionAlreadyExists (#5, registry). mint_verified is NotSafeVerdict (#4, tokens). Pipeline: 671 passed, 9 skipped.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: STE-50 · ACC by Axel 2026-09-17 · reviewers @axelmatsama @fable
Problem
ContractCallErrorresolved error names from the registry table for anything it did not recognise. The STE-27 rehearsal logged the Tokens gate refusing to licence a DANGEROUS version (#5 NotVerified) asVersionAlreadyExists (#5, registry).Fix
TOKENS_ERRORSadded, taken fromcontracts/tokens/src/data.rs::TokenError.REGISTRY_ERRORSgains STE-16: verdict mendarat on-chain — escrow kanonik dengan USDC asli #10–13. STE-44 added these upgrade errors and they were never copied.get_admin, the upgrade functions) or an unknown one reportscontract not identifiedand lists each candidate. It never guesses.simulate()/invoke()take an optionalcontract=.Tests
E2E (testnet, read-only simulate against Tokens v2, nothing signed)
mint_licenseon DANGEROUS release-notes 2.0.0VersionAlreadyExists (#5, registry)NotVerified (#5, tokens)mint_verifiedon the same versionNotSafeVerdict (#4, tokens)Evidence:
docs/evidence/ste-50-tokens-error-names-2026-09-17.json.