Repository navigation
STE-58: fit the CVE box to its text, and put the D3 evidence in the README - #74
Merged
Merged
Conversation
… evidence Two things, one visual and one that matters more. **The box.** The CVE line on the problem card still ran past its border: the box width was a guessed number and the text was wider than the guess. It is now measured from the text with `textlength` and drawn to fit, so the border holds whatever the line says. **The evidence is now in the README.** The Instawards report was submitted before the demo video and the screenshots existed, so that submission lists both as outstanding and it cannot be edited or resubmitted. The repository is what a reviewer opens next, so the first section after the intro is the evidence itself: the video URL, the screenshots, the evidence map, the raw recordings and the narration script, with the note that they were finished on 28 September, after the report went in. `docs/evidence/demo/README.md` carries the same note at the top for anyone who lands there first. Also corrects a badge that pointed at `dashboard.yml`, a workflow that no longer exists — the two apps are built by `frontend.yml` and `landing.yml` now, and both badges are live.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things.
The box bug
The CVE line on the problem card ran past its border — the width was a guessed constant and the text was wider than the guess. It is measured with
textlengthnow and the box is drawn to fit, so the border holds whatever the line says. Video re-rendered and verified frame by frame.The evidence belongs in the README
The Instawards report was submitted before the demo video and screenshots existed, so the submission lists both as outstanding and cannot be edited or resubmitted. The repository is what a reviewer opens next, so the first section after the intro is now the evidence itself:
docs/evidence/demo/screenshotsdocs/evidence/demo/README.mddocs/evidence/demo/*.castdocs/evidence/demo/narration.jsonWith the date stated plainly — finished 28 September, after the report went in — and the seven transactions re-checked on Horizon, 7 of 7 successful.
docs/evidence/demo/README.mdcarries the same note at the top for anyone who lands there first.Also fixes a README badge pointing at
dashboard.yml, a workflow that no longer exists; the two apps are built byfrontend.ymlandlanding.yml.cc @axel @fable @Nabil-Aufa