Merged
Conversation
Updated the setup_module function to enhance error logging by using mod_data.name instead of mod.__name__. Commented out the module entry point check and shelf handling for clarity, while ensuring that entry points are now managed with a _LazyEntryDict for better performance. This refactor aims to streamline the setup process for funcnodes modules.
Updated the _LazyEntryDict and InstalledModule classes to improve module loading logic. The changes include setting the installed module directly within the entry points and refining the set_module method to enforce module integrity. Additionally, removed print statements for cleaner code and better performance during module operations.
Updated the write_json_secure function to properly handle the cleanup of the temporary file in case of an exception. Introduced a check for temp_file_path before attempting to remove the file, enhancing error handling and preventing potential issues with undefined variables.
…ation Updated the wait_for_trigger_finish method to use a bounded wait for the 'triggerdone' event, preventing potential deadlocks. In the plugins module, refined entry point validation to ensure proper handling of EntryPoint instances and updated the module loading logic to enhance clarity and functionality.
Implemented the _repr_json_ method in the InstalledModule class to provide a JSON-compatible representation of the module's data. This addition enhances the usability of the InstalledModule for serialization and debugging purposes.
…est cases Introduced a new `yappicontext` fixture in `conftest.py` for profiling test performance using the yappi library. Updated existing tests in `test_nodeutils.py` and `test_triggering.py` to utilize this fixture, enhancing performance measurement capabilities and ensuring consistent profiling across tests.
Added a new _trigger_task attribute to the Node class for better management of asynchronous trigger tasks. Updated the wait_for_trigger_finish method to directly await the trigger task, improving responsiveness and reducing the risk of missing event pulses. Implemented a callback to clear the task reference upon completion, ensuring proper cleanup and state management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.