Merged
Conversation
…nfiguration management and update FuncNodesExternalWorker to utilize it
… and logging for configuration updates
…ance message enqueue handling
Fallback to a running loop when available, warn and skip when none is usable, and suppress deprecation warnings around event loop lookup.
Allow external worker configs to omit non-export fields during export. Track data paths, validate nodeshelf assignment, and emit updates on set. Provide optional export flag in serialize for packaging worker state.
Ensure external worker shelves are refreshed and references cleaned when workers restart, passing data paths to instances and forcing export mode when saving worker state.
Switch tests to pytest fixtures with pytest-funcnodes setup/teardown. Add coverage for nodeshelf refreshes and export filtering of configs.
Modify worker_kwargs and worker_case fixtures to dynamically generate UUIDs based on the test name. Adjust test assertions and remove unnecessary try-finally blocks for cleaner code. Update test decorators to support no prefix for specific tests.
… test structure Convert tests in test_client_connection.py from unittest to pytest, utilizing fixtures for logger setup. Enhance test readability and maintainability by removing the IsolatedAsyncioTestCase class and directly defining async test functions.
…tures Transform tests in test_socketworker.py from unittest to pytest, implementing fixtures for setup and teardown. This change enhances test organization and readability by removing the IsolatedAsyncioTestCase class and defining async test functions directly. Additionally, the use of pytest-funcnodes decorators streamlines the test execution process.
Eliminate the unused pytestmark variable from test_socketworker.py to clean up the code and improve clarity. This change contributes to maintaining a tidy test suite as part of the ongoing migration to pytest.
Transform tests in test_ws_worker.py from unittest to pytest, utilizing fixtures for setup and teardown. This change enhances test organization and readability by removing the IsolatedAsyncioTestCase class and defining async test functions directly. The use of pytest-funcnodes decorators further streamlines the test execution process.
Transform tests in test_loops.py from unittest to pytest, utilizing fixtures for setup and teardown. This change enhances test organization and readability by removing the IsolatedAsyncioTestCase class and defining async test functions directly. The use of pytest-funcnodes decorators further streamlines the test execution process.
- await cancelled loop tasks and give async_call tasks a timed grace period, even when stop runs inside the manager loop - guard async scheduling with closed/running loop checks to avoid unawaited coroutine warnings - add write/drain helper for socket worker to handle coroutine-returning mocks and real writers - clear stale worker process/runstate files on init and migrate external worker tests to pytest fixtures
…ker initialization - Updated FuncNodesExternalWorker to accept an optional name parameter during initialization. - Modified LocalWorkerLookupLoop and Worker classes to pass the new name and config parameters when starting local workers. - Enhanced add_local_worker method to support additional configuration options for external workers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.