Conversation
cjumel
marked this pull request as ready for review
May 19, 2026 14:05
cjumel
force-pushed
the
cj/ci
branch
2 times, most recently
from
May 19, 2026 15:04
e313773 to
11728cc
Compare
Lint checks where not enable in our CI. This commit fixes this and run the linting/formating of all files.
This commit update the repository tooling to be on par with our common practices: - update the `make` commands to follow the `lint`, `typecheck`, `test` split we have elsewhere - replace mypy with pyright in strict mode (just ignore the new errors for now) - update the ruff config
Shedna
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
practices:
makecommands to follow thelint,typecheck,testsplit we have elsewhereChecklist
prekon this project (for instance with themake install-devcommand)before creating any commit, or I have run successfully the
make format-lintcommand on mychanges.
make testcommand on my changes.README.mdif my changes affected it.