fix: handle fetch target not found errors - #89
Merged
Merged
Conversation
Co-authored-by: william <william@linkup.so>
Co-authored-by: william <william@linkup.so>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The public fetch API can return
FETCH_TARGET_NOT_FOUND, but the SDK previously treated it as a generic invalid request. This adds and exportsLinkupFetchTargetNotFoundError, maps the platform error code to it for sync and async calls, documents it, and covers both paths through the shared parametrized tests.Checklist
prekon this project (for instance with themake install-devcommand) before creating any commit, or I have run successfully themake lintcommand on my changes.make typecheck testcommand on my changes (112 tests passed).README.mdif my changes affected it (not applicable; no README behavior changed).