feat(escrow): enforce idempotency keys on funding submissions#247
Open
chisomvictorcv-sketch wants to merge 6 commits into
Open
feat(escrow): enforce idempotency keys on funding submissions#247chisomvictorcv-sketch wants to merge 6 commits into
chisomvictorcv-sketch wants to merge 6 commits into
Conversation
|
@chisomvictorcv-sketch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@drips-wave |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201
Summary
Adds durable idempotency-key enforcement to
POST /api/invest/fund-invoiceso identical retries return the original response instead of double-submitting.Changes
New:
src/middleware/idempotency.jsIdempotency-Keyheader against existingIDEMPOTENCY_KEY_PATTERNidempotency_keystableIDEMPOTENCY_KEY_TTL_HOURSenv (default 24h)New:
migrations/20260601000000_create_idempotency_keys.sqlidempotency_keystable with UUID PK, key, fingerprint, response, TTLModified:
src/routes/invest.jsidempotencyMiddlewareadded toPOST /fund-invoicebeforerequireKycForFundingNew:
tests/idempotency.test.js8 tests:
Security