Skip to content

test(escrow): snapshot immutability and over-funding capture#292

Merged
mikewheeleer merged 1 commit into
Liquifact:mainfrom
Edoscoba:test/snapshot-immutability
May 28, 2026
Merged

test(escrow): snapshot immutability and over-funding capture#292
mikewheeleer merged 1 commit into
Liquifact:mainfrom
Edoscoba:test/snapshot-immutability

Conversation

@Edoscoba
Copy link
Copy Markdown
Contributor

Summary

Adds tests proving FundingCloseSnapshot is created only when funding first crosses the target, captures the full over-funded funded_amount, records the close ledger timestamp/sequence, and remains immutable after later lifecycle actions or rejected same-ledger funding attempts.

Also updates snapshot documentation and rustdoc to clarify the write-once pro-rata denominator invariant.

Validation:

  • cargo test
  • cargo clippy -p liquifact_escrow --all-targets -- -D warnings
  • cargo llvm-cov --features testutils --fail-under-lines 95 --summary-only -p liquifact_escrow

close #258

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

@Edoscoba Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mikewheeleer mikewheeleer merged commit 3d4ec28 into Liquifact:main May 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test funding-close snapshot immutability across over-funding past funding_target

2 participants