This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Mario/issue208#218
Open
blamario wants to merge 11 commits into
Open
Conversation
Author
|
This is a fix for issue #208 if there's any doubt. |
kozross
suggested changes
May 3, 2022
| exposed-modules: Test.Plutus.ContextBuilder | ||
| exposed-modules: | ||
| Test.Plutus.ContextBuilder | ||
| , Test.Plutus.ContextBuilder.Internal |
Contributor
There was a problem hiding this comment.
I'd say 'minor version bump'. Also worth mentioning that everything in that module will need docs and @sinces if they weren't docced or exposed before.
Author
There was a problem hiding this comment.
I incremented the versions to 2.0.1 for plutus-context-builder and 9.1.1 for tasty-plutus. That's what minor means with PVP, right?
Author
|
The unit testing part is finished and could use a review. Property testing is going to require more time, perhaps should be left for another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still need to add some tests and review parts of the implementation.