Skip to content

fix(security): 修复 CodeQL 三类真实问题并判定 7 条误报/已缓解告警 - #39

Merged
xJasonShane merged 1 commit into
mainfrom
fix/code-scanning-alerts
Nov 9, 2026
Merged

xJasonShane merged 1 commit into
mainfrom
fix/code-scanning-alerts

Conversation

@xJasonShane

Copy link
Copy Markdown
Contributor

Summary

处理 code-scanning 10 条开放告警:3 类真实问题修复(本 PR),7 条 dismiss(误报/已缓解/测试代码,随合并另行操作)。

本 PR 修复

告警 规则 修复
#15 backup-restore.js file system race condition 封面恢复写入 access 预检 + writeFile 改 wx 独占创建:已存在原子失败即跳过,消除 check-then-write 窗口(真实风险:竞态下覆盖用户既有封面)
#12 model-export.js Incomplete string escaping mdCell **先转义 \ 再转义 `
#2 civitai.js Double escaping/unescaping stripHtml 实体解码由 6 段链式 replace 改单趟表映射:链式会把 &amp;lt; 二次解码为 <;单趟只解码一层,与 HTML 规范一致

判定 dismiss(不改动代码)

Test plan

- backup-restore 封面恢复写入改 wx 独占创建,消除 access 预检 + writeFile 的 check-then-write 竞态(#15)
- model-export mdCell 先行转义反斜杠再转义竖线,阻断自带 \ 吞掉转义符造成的表格单元格注入(#12)
- civitai stripHtml 实体解码改单趟表映射,消除链式 replace 的二次解码(#2);输出仅流向纯文本 sink,HTML 注入前提不成立(#1 按 FP 关闭)
- 回归测试 +3:双解码一层语义、Markdown 反斜杠/竖线转义
@xJasonShane
xJasonShane merged commit 2ae158c into main Nov 9, 2026
@xJasonShane
xJasonShane deleted the fix/code-scanning-alerts branch November 9, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant