feat(ui): add debug-log visibility toggle for chat - #6
Merged
Conversation
Code Review SummaryCorrectness ✓
Code Quality Issues
Edge Cases
Minor Suggestions
VerdictApprove - Functionally correct implementation. The double iteration is a minor optimization opportunity but not a regression risk. Missing tests should be addressed before merge. |
LiusCraft
force-pushed
the
feat/chat-debug-log-toggle
branch
from
March 14, 2026 15:54
3c24a1c to
6a6f790
Compare
|
Based on my review, the PR is functionally correct. The implementation:
The earlier review mentioned a double iteration inefficiency in No issues found that meet the high-confidence, actionable threshold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
show_debug_logssetting (persisted in local app settings) and expose it in the Settings panel under 会话显示Validation
cargo test -p host-app-gpui