Skip to content

Avoid duplicate no-issue comments in OpenCode PR review - #8

Closed
LiusCraft wants to merge 2 commits into
mainfrom
chore/opencode-pr-review-inline-suggestions-no-summary
Closed

Avoid duplicate no-issue comments in OpenCode PR review#8
LiusCraft wants to merge 2 commits into
mainfrom
chore/opencode-pr-review-inline-suggestions-no-summary

Conversation

@LiusCraft

Copy link
Copy Markdown
Owner

Background

  • OpenCode app already posts a run comment, so adding an extra no-issue review/comment creates duplicated PR timeline noise.

Changes

  • Updated .github/workflows/opencode-pr-review.yml prompt to submit pending reviews without a separate summary body after inline comments.
  • Removed no-issue review submission behavior by explicitly disallowing pending review creation, inline comments, and MCP review/comment posting when no issues are found.
  • Preserved existing inline-comment and suggestion-block guidance for real issues.

Behavior Impact

  • Issue findings still appear as inline review comments with actionable guidance.
  • No-issue runs now avoid additional MCP review/comment output, leaving only the OpenCode app run comment.
  • Workflow triggers, permissions, MCP server wiring, and token fallback behavior remain unchanged.

Risks and Rollback

  • Prompt-following depends on model adherence; occasional drift remains possible.
  • Removing no-issue MCP confirmation reduces explicit "clean pass" messaging in review threads.
  • Rollback by reverting .github/workflows/opencode-pr-review.yml to the previous prompt text.

Verification

  • Verified diff content to ensure no-issue path removes MCP review/comment actions.
  • Could not run end-to-end GitHub Action execution locally because PR review events and bot comments are GitHub-hosted.

Notes

  • No compatibility-breaking changes to workflow inputs, secrets, or permissions.
  • Reviewer focus: confirm duplicate no-issue timeline entries disappear while inline issue comments remain intact.

@LiusCraft LiusCraft closed this Mar 14, 2026
@github-actions

Copy link
Copy Markdown

I've reviewed this PR. Here's my analysis:

Changes Summary:

  • Modified .github/workflows/opencode-pr-review.yml to prevent duplicate no-issue comments
  • Changed prompt: when issues found → submit pending review without separate summary body
  • Changed prompt: when no issues found → avoid creating pending review or posting MCP comments

Review Findings:

  1. YAML Validity: Valid syntax, no parse errors.

  2. AGENTS.md Compliance: N/A - this is a CI workflow change, not application code. AGENTS.md has no rules scoped to GitHub workflow files.

  3. Correctness/Regression: No bugs. The changes are prompt instruction modifications that:

    • Preserve inline comment behavior for real issues
    • Prevent duplicate "no-issue" review comments
  4. Security: No security issues. No new permissions, secrets, or external dependencies.

  5. Logic: The conditional logic is sound - avoids duplicate timeline noise while preserving actionable inline comments.

Verdict: This PR is clean. No issues found.

New%20session%20-%202026-03-14T15%3A48%3A58.655Z
opencode session  |  github run

@LiusCraft
LiusCraft deleted the chore/opencode-pr-review-inline-suggestions-no-summary branch March 14, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant