Skip to content

fix(ci): address Sonar workflow findings - #985

Merged
ReenigneArcher merged 2 commits into
masterfrom
codex/fix-sonar-workflow-findings
Oct 30, 2026
Merged

ReenigneArcher merged 2 commits into
masterfrom
codex/fix-sonar-workflow-findings

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Description

Fix the 25 actionable Sonar findings in LizardByte_.github: redirect the 24 reported repository mirror error annotations to stderr (githubactions:S7677) and assign the C/C++ lint helper's directory argument to a descriptive local variable (githubactions:S7679). The existing combined log capture still collects the annotations for failure summaries.

Leave the existing TODO finding (githubactions:S1135) unchanged.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • npm test: all 132 existing tests passed.
  • yamllint --strict: both modified workflows passed using the locked lint dependencies.
  • actionlint 1.7.12: both modified workflows passed (optional ShellCheck integration disabled).
  • bash -n: all 24 Bash steps across the modified workflows passed.
  • git diff --check: passed.

The changes only adjust shell error redirection and name an existing parameter; no new automated test is needed.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 6c7bd49 into master Oct 30, 2026
21 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-sonar-workflow-findings branch October 30, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant