Skip to content

fix: route shared navigation to the main website - #526

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-shared-site-navigation
Nov 9, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-shared-site-navigation

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Project sites and Read the Docs project previews currently resolve shared LizardByte navigation under their own host and base path. For example, ThemerrDB's Store, Blog, and policy links point to pages absent from the database site, while its footer displays LizardByte's address but links to the project.

Use the shared url-canonical setting for the brand, navigation, footer, policy, and support links. Keep the project avatar and assets relative to the project. Main-site previews override the canonical address with their preview version path; project previews link to the published main site. Apply preview configuration last so project settings cannot replace its version path.

This fixes the shared-theme dependency for ThemerrDB #9926. Rebuild that preview after merging this PR; no hostname changes or deployment are performed by this PR.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • npm test: 44 tests passed with 100% JavaScript coverage; ESLint passed.
  • Added 14 Liquid rendering cases covering main/project production sites, both preview types, configurable hostnames, local assets, and explicit external destinations.
  • A local Ruby 3.3 / Jekyll 3.10 render harness passed 40 assertions against the actual navbar and footer across four production/preview contexts, including the footer site-address link.
  • Executed the Read the Docs configuration block for main-site and project previews; canonical addresses and config precedence passed.
  • ShellCheck, Bash syntax, yamllint, and git diff --check passed.
  • Full hosted site rendering and the rebuilt ThemerrDB preview remain separate CI/deployment checks.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c1e3af6) to head (c2c49af).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #526   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1047      1047           
  Branches       141       141           
=========================================
  Hits          1047      1047           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e3af6...c2c49af. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher
ReenigneArcher merged commit e502081 into master Nov 9, 2026
19 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-shared-site-navigation branch November 9, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant