Skip to content

feat: Add DMG casks and bump workflow - #419

Open
eduardomozart wants to merge 3 commits into
LizardByte:masterfrom
eduardomozart:add-sunshine-casks
Open

eduardomozart wants to merge 3 commits into
LizardByte:masterfrom
eduardomozart:add-sunshine-casks

Conversation

@eduardomozart

@eduardomozart eduardomozart commented Oct 10, 2026 •

Copy link
Copy Markdown

Description

This PR introduces Homebrew Casks for Sunshine stable and beta releases (Casks/sunshine.rb and Casks/sunshine-beta.rb). These casks install the pre-built .dmg bundles directly, providing an alternative to compiling from source and ensuring users receive a .app bundle that properly interfaces with macOS Privacy & Security permissions (e.g., Screen Recording).
These static templates are designed to be automatically bumped by the centralized release pipeline. When a new upstream release is published, the central pipeline will invoke Homebrew/actions/bump-packages to natively scan the livecheck blocks in these Casks and open concurrent version bump PRs.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Validated the new cask files locally using brew style --fix and brew audit --cask --strict --online.
  • Added audit_exceptions/github_prerelease_allowlist.json to successfully suppress the Homebrew pre-release audit failure for the sunshine-beta cask.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@CLAassistant

CLAassistant commented Oct 10, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ReenigneArcher ReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. This is something that's been in the back of my mind for a while now.

I think this might need a little more thought though.

  1. Other casks will be available here in the future. We need to make sure this is not too specific to Sunshine, but can work for future casks as well. I think homebrew has a way to do a livecheck and update affected formulas/casks.
  2. We currently update the Sunshine (stable) beta on every release event in Sunshine automatically. It would be ideal if both the cask and formula were updated together. Similarly, for Sunshine (beta), it's updated automatically when we create the beta release in Sunshine's repo.

Not really sure the best way forward, but these are my initial thoughts on it.

@eduardomozart

Copy link
Copy Markdown
Author

Thanks for this. This is something that's been in the back of my mind for a while now.

I think this might need a little more thought though.

  1. Other casks will be available here in the future. We need to make sure this is not too specific to Sunshine, but can work for future casks as well. I think homebrew has a way to do a livecheck and update affected formulas/casks.
  2. We currently update the Sunshine (stable) beta on every release event in Sunshine automatically. It would be ideal if both the cask and formula were updated together. Similarly, for Sunshine (beta), it's updated automatically when we create the beta release in Sunshine's repo.

Not really sure the best way forward, but these are my initial thoughts on it.

I've shifted the architecture to use official Homebrew tooling:

  1. Keep it Static Here: I've stripped all custom GitHub Actions update logic out of this homebrew-homebrew PR. It now strictly contains just the static Cask templates, which are natively configured with livecheck blocks.
  2. Centralized Generic Bumping: In LizardByte/.github, I've opened a companion PR feat(macos): Natively bump casks during homebrew repo updates .github#967 that appends the official Homebrew/actions/bump-packages action to the end of the __call-update-homebrew-repo.yml workflow.

Because of this, whenever a release goes live, the central pipeline will bump the Formula and then immediately run a native brew livecheck across the entire homebrew-homebrew tap. If it finds outdated Casks, it automatically fetches the new DMG SHAs and opens concurrent Cask PRs.

This completely decouples the update logic from Sunshine specifically, meaning any future Casks you add to this tap will be automatically supported with zero extra configuration! Let me know what you think of this setup.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants