One switch for self-upgrade, not two - #10
Merged
Merged
Conversation
NUDO_ALLOW_SELF_UPGRADE is gone; the dashboard toggle is the whole gate. The flag existed on the theory that whoever installs an instance and whoever operates it are different people, and both should have to say yes. For a tool one person installs and operates on their own box, that was a second lock on the same door. Its only visible effect was a dashboard that refused an upgrade someone had already opted into, and a "now also set this environment variable" instruction repeated across the upgrade page, the settings page, the unit file and the README. The packaged unit has always put a fresh install in the release layout, so a new install now needs exactly one thing to be able to upgrade itself: the tick in settings. Nothing about the security of the path changes — the release is still verified against the digest published in the manifest, still staged beside the running one, still reverted by the boot guard if it cannot start, and a container or a flat /usr/local/bin install is still refused. The proto field is reserved rather than reused, since 0.4.0 published it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NUDO_ALLOW_SELF_UPGRADEis gone; the dashboard toggle is the whole gate.The flag existed on the theory that whoever installs an instance and whoever operates it are different people, and both should have to say yes. For a tool one person installs and operates on their own box, that was a second lock on the same door — its only visible effect was a dashboard that refused an upgrade someone had already opted into, plus a "now also set this environment variable" instruction repeated across the upgrade page, the settings page, the unit file and the README.
The packaged unit has always put a fresh install in the release layout, so a new install now needs exactly one thing to upgrade itself: the tick in settings.
Nothing about the security of the path changes. The release is still verified against the digest published in the manifest, still staged beside the running one, still reverted by
nudo-boot-guardif it cannot start; a container or a flat/usr/local/bininstall is still refused, and the upgrade is still off until someone says otherwise.The proto field is
reservedrather than reused, since 0.4.0 published it.Verified against a real instance with no env var set: before the tick the page explains where to switch it on and shows no button; after one tick the button appears.
fmt,clippy -D warningsand all 23 suites pass.