Correct the dashboard's batching rationale - #17
Merged
Conversation
#15 batched the dashboard's independent reads and justified it with each one opening its own connection to the control plane. #16 made that false: the reads now share one lazily-connected, multiplexed channel. The batching is still right — four round trips in series to learn four independent things is four too many — but sharing a connection is what makes asking at once cheap rather than contended, so that is what the comment says. The two branches merge without conflict; this is the only place where one made the other's reasoning untrue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. Found while reconciling #15 and #16, which merge without
conflict but leave one piece of reasoning untrue.
#15 batched the dashboard's independent reads and justified it with each one
opening its own connection to the control plane. #16 made that false: the
reads now share one lazily-connected, multiplexed channel.
The batching is still right — four round trips in series to learn four
independent things is four too many — but sharing a connection is what makes
asking at once cheap rather than contended, so that is what the comment says
now.
Verified on the merged tree before either landed:
make check(1004 tests),the Docker e2e suite 14/14, and a full
make demorun deploying all threeexample services through the rebuilt CLI.