Repository navigation
Conversation
|
Requires LocalExile Update: this mod needs LocalExile/LocalExile#790 to be merged first. The mod will be reviewed once that pull request is merged, and before merging the maintainer will set Two questions for @ou3051, following the updated AGENTS.md:
|
|
Thanks for checking. Please credit me as JJ ouyang in Waypoint. I have updated The icon shows a wand and sword joined by a magical binding, representing preserved donor equipment contributing its properties to a target item. It is AI-assisted original artwork based on the repository's in-game screenshots and the mod's feature description, rather than an extracted client asset.
I understand that this PR must wait for LocalExile#790 and retain the Requires LocalExile Update label. Please set — JJ ouyang |
The mod infrastructure has changed (LocalExile 0.4.1-beta)Hi, and thanks for this PR. LocalExile/LocalExile#818 is merged and shipped in LocalExile v0.4.1-beta. It changes how every mod hooks into the server, so this PR no longer builds as it is. I've moved it to draft until it's updated; mark it ready for review again once it builds against What changed
How the old calls translate
The official mods were ported this way in #26; Before marking it ready again
For this PR
|
ec63e70 to
026b162
Compare
|
Requires LocalExile Update: LocalExile #1155 is the current prerequisite and must merge first. It replaces the closed #790 with native skin-transfer persistence and the general owner-scoped Status rechecked on 2026-11-19: #1155 is still open and unmerged, and neither PR has new review submissions or inline comments. Equipment Fusion is 2.0.2 at The cloud Mod index run is This PR remains draft under the repository's Reviewing rule until #1155 merges. After merge, the mod must be checked against the finalized main/API before being marked ready. A maintainer sets the first compatible shipping release before merging or publishing the mod. The author account cannot add labels ( — JJ ouyang |
|
The requested updates are complete in
Following the Reviewing rule, this PR stays draft until #1155 merges. Please apply Requires LocalExile Update (author label changes were denied); the maintainer selects the shipping compatibility version. The previous draft's implementation feedback is addressed, but the new API dependency must be reviewed first. — JJ ouyang |
Equipment Fusion automatically adds a native skin-transfer donor's numerical attributes and independently calculated local defences on non-weapon equipment. Each target keeps one complete donor; native game actions select, bind and reclaim equipment. The GM tool only installs the mod, switches it and shows actual status.
Requires LocalExile Update: LocalExile #1155 must merge first. This supersedes the closed #790 prerequisite. The current mod uses owner-scoped
GameEvents.ItemStatSourcesandItem.SkinTransferSource; it adds no method toIModContext. The provisional0.5.2-betaentry is required by repository rules, not a claim that the unchanged release supports this mod. The maintainer must set the first release containing the prerequisite before merging/publication.Behavior
Validation
e873c55ac2d245e44ade722e9fe81ff3aef5c1ed; head41cce1f9cbd099e0464c48d4bd3efb62fdb02f65. Both repositories freshly fetched; bases unchanged.fc825ab1c658d003637943929a4fe18107956e6d; exact paired head395b969b600abda65dee5163a3f9b53626fb3eb3. This mod cannot build against unchanged main until that prerequisite merges.tools/build-index.ps1 -Check: current, 12 mods. Version and generated index updated; no binaries committed.Real 3.29.3c client (3.29.3.5 hotfix, build 328126), the same synthetic character/equipment, area
1_1_1, seed168432811, position(290,229)and Frostbolt target(293,229). Thirty level-100 normal GravelEaters stay alive in every run;/god immuneand/set_stat damage_+% -99stabilize the workload. Each condition uses a fresh Release Gateway withGame_TRACE=lag,latency, 15 s warmup and 75 s continuous casting. The first partial 10 s logging interval is discarded, leaving 6–7 complete intervals. No module changes occur within the accepted samples.CPU is the logger's stat-build CPU as a percentage of one core, rounded to integer percentage points; this single controlled run per condition cannot establish a sub-1-point difference. The cached lookup figure is the whole item-stat lookup, not just the mod provider. A separate 100,000-hit provider check takes about 0.149 us/call and allocates zero managed bytes. A sample disturbed by Debug's automatic module deployment was rejected and replaced with a clean Release run.
The native picker requires B's sockets empty; gem-bearing donors and reclaim were verified through native protocol packets. Shift-click reclaim and 3.29.3d were not exercised. The client remains 3.29; no game files or archive writes are included.
Additional Linux x64 Release validation on 2026-11-19 used the exact paired heads above. A real 3.29.3c client authenticated and entered an area; the GM tool queried the remote mod list, disabled/enabled Equipment Fusion 2.0.2 and reloaded it successfully. The mod ended enabled with one hook, and the server log had no retained-context or private-copy cleanup warning. This adds deployment evidence; the prerequisite remains unmerged and the review order is unchanged.
Review order
This remains draft solely for its unmerged LocalExile dependency, following the repository's Reviewing rule: review/merge #1155 first, then review this mod against the finalized API. The prior API, author, icon, version/index and live unload feedback is addressed. Maintainers set the shipping compatible version and handle releases. The author cannot add
Requires LocalExile Updatebecause GitHub deniedAddLabelsToLabelable; please apply it. No approval, merge, tag or release was performed.