Repository navigation
fix(pob): encode cluster themes with native one-based ids - #50
Merged
Merged
Conversation
4 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Correct the native theme identifier written into a cluster jewel's
JewelExpansionPassiveNodesenchantment. The converter matched a PoB cluster skill to a zero-basedPassiveTreeExpansionSkillsrow, then wrote that row directly. The native enchantment reserves zero and stores row + 1. Consequently, imports could succeed without warnings while assigning the previous theme and its passive statistics.For the supplied build, all four three-passive small clusters should use reservation-efficiency row 53. They were encoded as
[53, 3], selecting the Intelligence theme instead. They now encode[54, 3]. The same correction applies to every recognized cluster theme; passive counts, explicit modifier rolls and allocations are preserved.This fixes a semantic conversion error rather than suppressing diagnostics or weakening strict validation. Existing unknown-theme diagnostics are unchanged.
Bump POB from 1.0.3 to 1.0.4 and regenerate
mods.json. The README explains that users must rebuild/update their separately configured converter and reimport an affected build once. Installing the frontend alone does not rewrite saved jewels, and there is no blanket migration of all jewels whose value is 53, which is a valid identifier for another theme.Layer
Mod —
mods/pob/Converter/, plus the POB manifest, README and generated catalog index. No converter executable, extracted tables, native catalog, user builds, account data or local paths are included.Issue
No linked issue. Found while comparing an imported build's reservation efficiency with its original PoB.
Checks
5686bd10ef0e6684f734b1679e84e51b1a43d053.e1ffa77aa9ac784c0b2a880d6d99645de78530bb.tools/build-index.ps1andtools/build-index.ps1 -Check; generated index matches POB 1.0.4.[54, 3].compatibleClientVersionsincludes0.5.2-beta, the latest LocalExile release checked at merge review on 2026-11-19. This encoding correction uses the existing released item format and needs no new server API.Existing saved jewels remain unchanged until the user reimports with the rebuilt converter. The frontend alone does not rewrite saved items. No new full-corpus audit or independent native whole-build parity run is claimed for this one-line correction.
Companion aura/Smite server PR LocalExile/LocalExile#1135 has merged. This PR's encoding fix has no API dependency on it.