Repository navigation
fix(stash): retain categories on repeated Unique tab requests - #1000
Merged
evrydayjunglist merged 2 commits intoNov 18, 2026
Merged
evrydayjunglist merged 2 commits into
evrydayjunglist merged 2 commits into
Conversation
7 of 11 tasks
evrydayjunglist
marked this pull request as ready for review
November 18, 2026 07:23
evrydayjunglist
approved these changes
Nov 18, 2026
evrydayjunglist
left a comment
Collaborator
There was a problem hiding this comment.
Picked this up and merged main in (1bc5d36). The build and all three suites pass (Core 443, Data 43, Gateway 594), and the new test fails on main and passes with the fix. On 3.29.3c, asking for the Unique tab again no longer unloads and re-registers its 22 categories. The #998 crash dump is on switching away from the Unique tab, which this doesn’t touch, so the description now says Refs rather than Closes. Thanks for the careful work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
After the first-open selection window expires, another request for the same Unique Collection tab unloaded its own hidden category inventories, sent the tab list with them marked not loaded, and registered them all again in the same burst (live on main: 22 × 0xc1, then 23 registrations, for one 0xc7). The selected Unique tab now keeps its registered categories. Switching to another tab still unloads that family; other families and ordinary tabs can still be unloaded, and shop-currency tabs stay registered.
The change is one condition in the unload predicate in
Modules/Core/Game/Item/Stash.cs. ExplicitRefreshUniqueCollectionstill removes and registers category inventories on purpose, and the inventory-change reload path is unchanged.This removes the reopen churn. It is not shown to fix the freeze or crash reported in #998: the crash dump posted there happens when switching from the Unique tab to the Delirium tab, which this PR does not change.
Layer
Module:
Modules/Core/Game/Item/Stash.cs.Gateway regression tests:
tests/GameServer.Gateway.Tests/StashTabReloadTests.cs.Status and roadmap:
Agents/status/stash.md,Agents/roadmap/stash.md.Issue
Refs #998 (does not close it).
Checks
main:bc95d68c4(merged into the branch as1bc5d36c5)1bc5d36c5dotnet build GameServer.slnx: 0 warnings, 0 errorsStash.csand passes with this changeFor the reviewer
Wirehelper; production adds none.sql/.github/CODEOWNERS