Repository navigation
fix: socket Abyss jewels and apply their active equipment stats - #830
2 commits merged into
Conversation
ac72119
|
Included in the batch #849 (not merged yet), at this PR's head a19d15e on main a6e3b6a. Tested on the combined batch: solution build clean, Gateway 280/280 on three runs, Data 45/45, Core 435/436 (the one failure is the HNC mask test, which needs a 3.29.3c client and fails on main too), docs scan clean. Not checked in the live client. Thanks! The socket rules look right: ordinary sockets refuse Abyss jewels, Abyss sockets refuse gems, eyes stay out of the gem lists and experience, only active hosts count, and a socketed eye raises the host's level requirement. Darkness Enthroned's effect applies only to non-local values, and all the eye-count stat ids exist. In the batch, the new status text in Follow-ups:
|
Abyss jewels can be placed in allocated passive jewel sockets and equipment Abyss sockets. Ordinary sockets reject them, Abyss sockets reject skill gems, and socketed eyes are excluded from skill gem lists and experience. An active host contributes its jewel modifiers once. Darkness Enthroned applies the local socketed-jewel effect. Counts include rarity, total eyes, individual eye types and the number of different eye types.
Stygian Vises generate Abyss sockets. Empty old Vises with missing or ordinary sockets recover the layout implied by their saved mods, preserving occupied old layouts. This covers the two socket destinations and the shared stat path. Special Gaze, Historic and skill-specific effects still need their respective gameplay implementations.
A native 3.29.3c Witch's fire resistance went 0 → 10 with a Murderous Eye in an ordinary tree socket, then 10 → 20 with another eye socketed into the equipped Stygian Vise. It remained 20 after returning to character select and re-entering, and returned to 10 when the belt was unequipped. Automated checks also exercise explicit unsocket, old empty layouts, persistence, incompatible sockets, effect scaling and counts.
Tested main a6e3b6a with final head a19d15e. Release solution, Gateway 246/246, Core 434/434 and Data 45/45 passed. The final active-item aggregation now merges cleanly with the equipment attachment work in #790 at 5c6cbb1. A separate integration checkout containing both and the other jewel heads passed the solution build and Gateway 261/261. The native socket and relog results above were measured before the aggregation refactor.
Fixes #563.