Skip to content

fix: socket Abyss jewels and apply their active equipment stats - #830

Merged
2 commits merged into
LocalExile:mainfrom
zj1022:codex/abyss-jewel-sockets
Nov 11, 2026
Merged

2 commits merged into
LocalExile:mainfrom
zj1022:codex/abyss-jewel-sockets

Conversation

@zj1022

@zj1022 zj1022 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Abyss jewels can be placed in allocated passive jewel sockets and equipment Abyss sockets. Ordinary sockets reject them, Abyss sockets reject skill gems, and socketed eyes are excluded from skill gem lists and experience. An active host contributes its jewel modifiers once. Darkness Enthroned applies the local socketed-jewel effect. Counts include rarity, total eyes, individual eye types and the number of different eye types.

Stygian Vises generate Abyss sockets. Empty old Vises with missing or ordinary sockets recover the layout implied by their saved mods, preserving occupied old layouts. This covers the two socket destinations and the shared stat path. Special Gaze, Historic and skill-specific effects still need their respective gameplay implementations.

A native 3.29.3c Witch's fire resistance went 0 → 10 with a Murderous Eye in an ordinary tree socket, then 10 → 20 with another eye socketed into the equipped Stygian Vise. It remained 20 after returning to character select and re-entering, and returned to 10 when the belt was unequipped. Automated checks also exercise explicit unsocket, old empty layouts, persistence, incompatible sockets, effect scaling and counts.

Tested main a6e3b6a with final head a19d15e. Release solution, Gateway 246/246, Core 434/434 and Data 45/45 passed. The final active-item aggregation now merges cleanly with the equipment attachment work in #790 at 5c6cbb1. A separate integration checkout containing both and the other jewel heads passed the solution build and Gateway 261/261. The native socket and relog results above were measured before the aggregation refactor.

Fixes #563.

@evrydayjunglist

Copy link
Copy Markdown
Collaborator

Included in the batch #849 (not merged yet), at this PR's head a19d15e on main a6e3b6a. Tested on the combined batch: solution build clean, Gateway 280/280 on three runs, Data 45/45, Core 435/436 (the one failure is the HNC mask test, which needs a 3.29.3c client and fails on main too), docs scan clean. Not checked in the live client.

Thanks! The socket rules look right: ordinary sockets refuse Abyss jewels, Abyss sockets refuse gems, eyes stay out of the gem lists and experience, only active hosts count, and a socketed eye raises the host's level requirement. Darkness Enthroned's effect applies only to non-local values, and all the eye-count stat ids exist.

In the batch, the new status text in Agents/status/items-and-crafting.md had landed in the middle of the "Seen in the client ...: Tulfall, Shimmeron, ..." list; it was moved after the list. The stale roadmap lines about the Stygian Vise socket (roadmap/skills-and-combat.md, roadmap/unique-jewels.md) were updated.

Follow-ups:

  • Abyss sockets are created by checking the Stygian Vise's type id (AbyssJewels.cs:5, UniqueCatalog.cs:161). Other uniques with abyss sockets (Lightpoacher, Bubonic Trail, Tombfist, Shroud of the Lightless, Hale Negator, Command of the Pit) still get none; local_has_X_abyss_sockets is already read and could drive this in general.
  • number_of_abyss_jewels and number_of_abyss_jewel_types are IsVirtual in Stats.dat, and the server writes them into the sources (AbyssJewels.cs:47,60); worth checking the client does not derive them too.
  • GemRequirementSnapshot.PlacesIn (GemRequirements.cs:12) still lists eyes as gems; every consumer filters them out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abyss jewels cannot be placed in passive or equipment sockets, and need stat aggregation

2 participants