Skip to content

Offer Ruthless only where it fits, worked out from the league files - #28

Merged
evrydayjunglist merged 1 commit into
mainfrom
fix/mode-modules
Nov 10, 2026
Merged

evrydayjunglist merged 1 commit into
mainfrom
fix/mode-modules

Conversation

@evrydayjunglist

Copy link
Copy Markdown
Collaborator

Why

Since #27 any module can be ticked for any league, so Ruthless could be turned on for Standard. The Ruthless module is not a few multipliers: it hands LocalExile a league's whole rules, for every character there, and LocalExile takes a league's rules from one module without merging. The rest of the mode (its own skills, vendors and quest rewards) belongs to the league's dataSet, which a module does not change.

What changes

A module counts as "the rules of a game mode" when every league LocalExile ships that lists it has the same form. Today that is Ruthless and the form ruthless. Nothing in the code names a module or a mode; once a shipped league of another mode lists the module, it is a module like any other.

Such a module is offered:

  • in a league of that mode, as its own bundle (unchanged);
  • in a league made in Waypoint, or about to be made, on a game base LocalExile ships that mode for: one that starts from Standard, Allflame or Phrecia, not one that starts from Survivors.

The leagues LocalExile ships in another mode do not get it. There it shows under Unavailable modules as Rules of a game mode, and its tooltip names the flags a new league can start from.

One that is already on where it does not fit (a hand edit of data/league-modules.json) stays ticked until its user unticks it, and other changes still save. It cannot be turned on anew there. The adapter (LeagueData.py) repeats the same checks.

What the user is told

  • Once ticked, the line under the list and the question before saving say that every character of the league gets that mode's rules from the next server start, without that mode's own skills, vendors and quest rewards, and that the game still shows the league as it is.
  • A new league says the same and, where its starting flag has a league of that mode to copy, that the whole mode is a choice of the first step.
  • In a league made in Waypoint it is an extra, not part of the league's bundle: unticking it takes it back without a question.

Also

Checked

  • dotnet build Waypoint.slnx and dotnet build Waypoint.Linux.slnx: 0 warnings.
  • Waypoint.Tests 397, Launcher.Checks 197, all adapter tests/*.Tests.ps1 and the Python suites pass.
  • Against LocalExile v0.3.0-beta's real league files: allowed for a league made from Standard, Allflame or Phrecia, refused for one made from Survivors and for every shipped league of another mode.
  • In the Windows app on a release folder: Standard, a league made in Waypoint (tick, save, untick), and a new league from Standard and from Survivors.

Not checked

  • No server was started with a league that has the rules ticked.
  • The Linux app was built, not run.
  • The translations were not reviewed by a fluent reader.

🤖 Generated with Claude Code

…gues

Since any module can be ticked for any league, Ruthless could be turned on
for Standard. The Ruthless module is not a few multipliers: it hands
LocalExile a league's whole rules, for every character there, and
LocalExile takes them from one module without merging. The rest of the
mode (its own skills, vendors and quest rewards) belongs to the league's
dataSet, which a module does not change.

The rule (LeagueCustomization.cs, LeagueData.py)
- ModeOf: a module is the rules of a game mode when every league
  LocalExile ships that lists it has the same form. That is Ruthless and
  the form "ruthless" today. Nothing names a module or a mode: once a
  shipped league of another mode lists the module, it is a module like any
  other.
- It is offered in a league of that mode (its own bundle, as before) and
  in a league made in Waypoint, or about to be made, on a game base that
  LocalExile ships that mode for: one that starts from Standard, Allflame
  or Phrecia, not one that starts from Survivors.
- The leagues LocalExile ships in another mode do not get it; they have
  their own versions in that mode. There it shows under "Unavailable
  modules" as "Rules of a game mode", and its tooltip names the flags a
  new league can start from (ModeStarts).
- One that is already on where it does not fit, by a hand edit of
  data/league-modules.json, stays ticked until its user unticks it, and
  other changes still save. It is not turned on anew.

What its user is told (GameSystemsTab.cs, GameSystemsTab.Draft.cs)
- Once ticked, the line under the list and the question before saving say
  that every character of the league gets that mode's rules from the next
  server start, without that mode's own skills, vendors and quest rewards,
  and that the game still shows the league as it is.
- A new league says the same and, where its starting flag has a league of
  that mode to copy, that the whole mode is a choice of the first step.
- In a league made in Waypoint it is an extra, not part of the league's
  bundle: unticking it takes it back without a question.

Also
- docs/launcher.md: a paragraph that still described the rule removed in
  #27 (a selection had to match a shipped combination) is gone.
- The catalogs lose the one text this change leaves unused.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@evrydayjunglist
evrydayjunglist merged commit 21ba2b8 into main Nov 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant