Skip to content

fix: extract only what the servers read on a split-database checkout - #29

Merged
Wrathen merged 2 commits into
mainfrom
fix/extract-servers-check
Nov 10, 2026
Merged

Wrathen merged 2 commits into
mainfrom
fix/extract-servers-check

Conversation

@Wrathen

@Wrathen Wrathen commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Problem

On a checkout from after LocalExile's database split, setup's Extract the game data step (and the Control section's extract -List) still ran the whole 16-entry manifest of extract-data.ps1. The servers only need the two entries marked Servers (client-constants and game-pack).

The cause is in SetupSequence.ExtractsForServers: its pattern \[switch\]\$Servers ended in a literal backspace character (0x08) where the \b word boundary was meant. No script contains a backspace, so the check always returned false and Waypoint never passed -Servers. It was the only control character in the repository's sources.

Changes

  • src/Launcher.Core/SetupGuide.cs: replace the backspace with \b.
  • tests/Launcher.Checks/SetupChecks.cs: three new checks:
    • a script that takes -Servers is detected
    • one from before the split, or one with a longer Servers… name, is not
    • a missing script falls back to the full extraction

An earlier commit here also changed the documented publish command; the second commit reverts it, so the docs are as on main.

Checks

  • dotnet build Waypoint.slnx: 0 warnings
  • dotnet test Waypoint.slnx: 397 passed
  • tests/Launcher.Checks: 200 passed, including the three new checks
  • tools/missing-translations.py: nothing missing (no interface text changed)
  • Adapter tests/*.Tests.ps1: 9 of 11 pass. ModControl ("selected source builds use the real .NET build…") and Mods fail in the same way without this change: scripts/ and those tests are identical to main. The Mods failure is a 263-character temp path, over Windows PowerShell's 260-character limit.
  • In the running app: I confirmed the bug against a real checkout. The released check returns false on LocalExile 745838dd, whose script takes -Servers. The fixed check returns true on a copy of that script's param line. I haven't yet seen a setup run end to end with [1/2].

🤖 Generated with Claude Code

Wrathen and others added 2 commits November 10, 2026 15:46
The -Servers check in SetupSequence.ExtractsForServers had a literal
backspace (0x08) in its pattern where a \b word boundary was meant, so
it never matched. Setup, and the Control section's -List, ran the
whole 16-entry manifest instead of the two entries the servers read.
A Launcher.Checks case now covers the check.

The documented `dotnet publish src/Waypoint -o .` also failed on SDK
10.0.403: the output folder reaches Launcher.Core, and the SDK leaves
files under it out of the sources, so nothing compiled (CS0246). The
README, docs/launcher.md and Waypoint.csproj now publish to publish\,
which is git-ignored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reverts the README, docs/launcher.md, Waypoint.csproj comment and
.gitignore changes that moved `dotnet publish src/Waypoint -o .` to a
publish\ folder. This pull request is only the -Servers check fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Wrathen
Wrathen merged commit 3c2860f into main Nov 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant